Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help]: 设置 countEL和 pvEl 无效 #905

Closed
everfu opened this issue May 31, 2024 · 7 comments
Closed

[Help]: 设置 countEL和 pvEl 无效 #905

everfu opened this issue May 31, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@everfu
Copy link
Contributor

everfu commented May 31, 2024

我是这么设置的,但是不生效
image

@everfu
Copy link
Contributor Author

everfu commented May 31, 2024

image

@everfu
Copy link
Contributor Author

everfu commented May 31, 2024

后台设置比前台绑定优先级高
image

@qwqcode
Copy link
Member

qwqcode commented May 31, 2024

🤔️ 我猜测可能是后端程序把前端的配置覆盖了的问题,界面配置目前的优先级是这样的:https://artalk.js.org/guide/frontend/config.html

@qwqcode
Copy link
Member

qwqcode commented May 31, 2024

也许我应该将优先级改为:

前端代码 > 后端配置文件

修改后,提供一个选项“强制覆盖前端配置”,默认优先级是:前端代码 > 后端配置文件,启用这个选项后才是后端配置文件 > 前端代码

这样能方便主题更好地适配 Artalk。

不过这会是一个破坏性变更,需要考虑社区的历史版本兼容性问题,你有什么好的建议吗?

@Mister-Hope
Copy link
Collaborator

Mister-Hope commented May 31, 2024

我的建议是不要给后端任何DOM相关的能力

@qwqcode
Copy link
Member

qwqcode commented May 31, 2024

我的建议是不要给后端任何DOM相关的能力

确实,pvElcountElstatPageKeyAttr 这些操作 DOM 的选项可以在后端设置列表中移除,不允许在后端配置,因为一般也没有动态修改的需求

@everfu
Copy link
Contributor Author

everfu commented May 31, 2024

我的建议是不要给后端任何DOM相关的能力

确实,pvElcountElstatPageKeyAttr 这些操作 DOM 的选项可以在后端设置列表中移除,不允许在后端配置,因为一般也没有动态修改的需求

是的,交给前端,没有指定就是默认的设置

qwqcode added a commit that referenced this issue Jun 1, 2024
@qwqcode qwqcode added the enhancement New feature or request label Jun 1, 2024
@qwqcode qwqcode closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants