[PORT] Crew Record Refactor + TGUI Records Consoles! #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request I have attempted or otherwise started this project at least 4 times. I am sick of it being on my calendar. The code needs it. I need it. - This makes crew records a proper datum rather than assigning properties record.fields. - General, medical, and security records are merged. - Did some slight refactoring here and there for things that looked obvious. - Wanted states are now defined (and you can suspect someone through sechud) - pAI (unrelated but annoying) had some poorly named exported types that i made more specific - Job icons are moved back to the JS side (I wanted to get icons for initial rank without passing trim) <details> <summary>previews</summary> Editable fields & security console  Medical records  Look and feel of the more current version  </details> ## Why It's Good For The Game TGUI'd some of the worst UIs in the game. Creating new records is made much simpler. Manifest_inject is made readable. Probably bug fixes ## Changelog :cl: refactor: Crew records have been refactored. refactor: Medical records -> TGUI refactor: Security records -> TGUI refactor: Warrants console -> TGUI qol: Players are now alerted when their fines are paid off. qol: Cleaned up sec hud examination text. qol: Adding and deleting crimes is easier. qol: Writing crimes in the console sets players to arrest. qol: You can now mark someone as a suspect through sec hud. /:cl: Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> # Conflicts: # code/__DEFINES/security.dm # code/datums/id_trim/_id_trim.dm # code/datums/id_trim/jobs.dm # code/game/machinery/computer/_computer.dm # code/game/machinery/computer/medical.dm # code/game/machinery/computer/security.dm # code/modules/admin/verbs/admingame.dm # code/modules/admin/verbs/list_exposer.dm # code/modules/jobs/job_types/prisoner.dm # code/modules/mob/living/carbon/human/human.dm # code/modules/modular_computers/file_system/programs/crewmanifest.dm # tgstation.dme # tgui/packages/tgui/interfaces/JobSelection.tsx # tgui/packages/tgui/interfaces/Orbit/index.tsx # tgui/packages/tgui/interfaces/PreferencesMenu/MainPage.tsx # tgui/packages/tgui/interfaces/common/JobToIcon.ts
github-actions
bot
added
Port
## About The Pull Request A few changes to sec records geared towards making it obvious how and why someone is wanted. - You can no longer set someone to arrest via console unless they have a valid prior. - Setting players to arrest via HUD creates a crime entry for that person. - Priors can be edited by the author and qualified personnel (armory access). - Priors can be invalidated by qualified personnel. This redacts the info from huds and rapsheets. - Invalidating the last crime sets a player to discharged - Much like real life, you can no longer outright delete crimes. This prevents gaming the arrest system by adding/deleting. - Deleting an individual record in a sec console removes it from the manifest (@JohnFulpWillard) this was previous behavior - Purging records in sec requires higher access ## Why It's Good For The Game Have you ever brought a wanted person into the brig only to find there's no reasons listed and no one in sec will explain why they're wanted? ## Changelog :cl: fix: Deleting a sec record removes it from the manifest again qol: It's now easier to see security notes via HUD. qol: It's now easier to see why someone is set to arrest. qol: Crime authors and armory access can edit crimes. balance: Setting players to arrest requires a valid crime. balance: Armory access can invalidate priors. balance: Setting players to arrest via HUD creates a crime for the suspect. /:cl: --------- Co-authored-by: Iamgoofball <iamgoofball@gmail.com> Co-authored-by: san7890 <the@san7890.com> # Conflicts: # code/game/machinery/computer/security.dm
## About The Pull Request A remake of #73169 Repaths records consoles to their own subtype Fixes some weirdness with observers logging into sec/med consoles Fixes security notes not being able to be set etc ## Why It's Good For The Game Bug fixes and cleaner code ## Changelog :cl: fix: Security can set notes through consoles again fix: Observers are now properly logged out of record consoles /:cl: --------- Co-authored-by: Jeremiah <jlsnow301@pm.me> # Conflicts: # _maps/RandomRuins/SpaceRuins/listeningstation.dmm # _maps/map_files/Deltastation/DeltaStation2.dmm # _maps/map_files/IceBoxStation/IceBoxStation.dmm # _maps/map_files/KiloStation/KiloStation.dmm # _maps/map_files/MetaStation/MetaStation.dmm # _maps/map_files/tramstation/tramstation.dmm # _maps/shuttles/emergency_cruise.dmm # _maps/shuttles/emergency_shadow.dmm # code/game/machinery/computer/_computer.dm # code/game/machinery/computer/records/medical.dm # code/game/machinery/computer/records/security.dm # tgstation.dme
github-actions
bot
added
Mapping
…(#74518) ## About The Pull Request This PR makes it so that the access modification program now updates the crew manifest once the inserted ID is ejected. Additionally, when the ID trim is changed, the manifest is updated. ## Why It's Good For The Game Demoted heads would still show up on the manifest as their job pre-demotion, this fixes that. ## Changelog :cl: fix: The crew manifest now properly updates after ID modifications. /:cl:
RimiNosha
added a commit
to RimiNosha/Nosha-Industries-Server
that referenced
this pull request
May 24, 2023
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Port of
Overhauls records to actually be sane, cause oh my fucking god, the old system is incredibly bad.
How Does This Help Gameplay?
Navigating records consoles is far less fucking painful, sec has more control over crimes.
Proof of Testing
Screenshots/Videos
Changelog
🆑
qol: Records consoles are now 1000% easier to use, and look way nicer!
/:cl: