Refactors crew records #72725
Merged
Refactors crew records #72725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShizCalev
requested changes
Jan 15, 2023
these awful var names are on the chopping block for sure. just getting it sorted before i start mass renaming vars |
|
just going to redo the security, medical, records consoles idc |
tgstation-server
added
the
UI
MrMelbert
reviewed
Jan 15, 2023
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
github-actions
bot
added
the
Merge Conflict
|
You should post the gifs you shared on the discord to the OP. Also you are doing god's work man! |
comfyorange
added a commit
that referenced
this pull request
Jan 24, 2023
wulfenbach-jpg
added a commit
to wulfenbach-jpg/tgstation
that referenced
this pull request
Jan 24, 2023
commit 038480c Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed Jan 25 07:39:28 2023 +1300 Automatic changelog for PR tgstation#72725 [ci skip] commit 5e80257 Author: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Date: Tue Jan 24 10:34:27 2023 -0800 Refactors crew records (tgstation#72725) ## About The Pull Request I have attempted or otherwise started this project at least 4 times. I am sick of it being on my calendar. The code needs it. I need it. - This makes crew records a proper datum rather than assigning properties record.fields. - General, medical, and security records are merged. - Did some slight refactoring here and there for things that looked obvious. - Wanted states are now defined (and you can suspect someone through sechud) - pAI (unrelated but annoying) had some poorly named exported types that i made more specific - Job icons are moved back to the JS side (I wanted to get icons for initial rank without passing trim) <details> <summary>previews</summary> Editable fields & security console  Medical records  Look and feel of the more current version  </details> ## Why It's Good For The Game TGUI'd some of the worst UIs in the game. Creating new records is made much simpler. Manifest_inject is made readable. Probably bug fixes ## Changelog 🆑 refactor: Crew records have been refactored. refactor: Medical records -> TGUI refactor: Security records -> TGUI refactor: Warrants console -> TGUI qol: Players are now alerted when their fines are paid off. qol: Cleaned up sec hud examination text. qol: Adding and deleting crimes is easier. qol: Writing crimes in the console sets players to arrest. qol: You can now mark someone as a suspect through sec hud. /🆑 Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> commit 9de8114 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed Jan 25 07:32:48 2023 +1300 Automatic changelog for PR tgstation#72885 [ci skip] commit b831784 Author: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Date: Wed Jan 25 00:02:24 2023 +0530 You now see the vibebot do its thing (tgstation#72885) ## About The Pull Request Fixes tgstation#72847 You now see the vibes and not just feel them ## Changelog 🆑 fix: vibebot being invisible /🆑 Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com> commit d39a30b Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed Jan 25 04:37:55 2023 +1300 Automatic changelog for PR tgstation#72862 [ci skip] commit 1b9b020 Author: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com> Date: Tue Jan 24 15:37:32 2023 +0000 Inspecting a trading card or card hologram now shows the full card art in chat. (tgstation#72862) ## About The Pull Request Does what it says in the title, example below.  ## Why It's Good For The Game TGC cards get shrunk down whenever you place them, making their card art very difficult to make out in a lot of cases, by doing this you can now view the full card art by inspecting the card rather than needing to pick it up. Placed Ian card for reference  ## Changelog 🆑 qol: Inspecting a trading card or card hologram will now let you see the full enlarged card art. /🆑 Co-authored-by: Time-Green <timkoster1@hotmail.com> commit 36ce31c Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed Jan 25 04:20:43 2023 +1300 Automatic changelog for PR tgstation#72838 [ci skip] commit 573b955 Author: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com> Date: Tue Jan 24 15:19:47 2023 +0000 Life and Mana bars for the TGC battle arena. (tgstation#72838) ## About The Pull Request Adds a life and mana bar for each player in the TGC holodeck arena, practically removing the need for players to keep track of these stats using items outside of the holodeck. The mana bar features a next turn button which will automatically increase the number of slots by 1 and refill or slots. You can inspect the panels to see these values numerically rather than visually.  ## Why It's Good For The Game I've set out on a goal on making the TGC battle arena a complete visualizer for the TGC game, where all you need to bring is a deck of cards and a friend. Adding this eliminates the need for pen and paper or an external notepad program for tracking life and mana, and replaces it with a far more visually interesting option that is also significantly easier for both players to see and keep track of. ## Changelog 🆑 add: The TGC arena on the holodeck now features display panels to track each player's life shards and mana. qol: Slightly increased the amount of space on the TGC holodeck arena's tables by removing the windows on either side of the player. /🆑 commit 8e98b07 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Wed Jan 25 01:19:02 2023 +1300 Automatic changelog for PR tgstation#72902 [ci skip] commit 1c2dbf9 Author: Zephyr <12817816+ZephyrTFA@users.noreply.github.com> Date: Tue Jan 24 07:17:07 2023 -0500 Fixes guest accounts not having keybinds and getting constant runtimes (tgstation#72818) ## About The Pull Request When loading values from the savefile for keybinds, it overrode the default values with null if not found. ## Why It's Good For The Game Resolves tgstation#72804 ## Changelog commit 8c9970e Author: san7890 <the@san7890.com> Date: Tue Jan 24 05:14:53 2023 -0700 Allows MODSuit AIs to count towards Steal AI Traitor Objective (tgstation#72902) ## About The Pull Request On the tin. It was simpler than it looked, just had to genericize the behavior a tad bit (the proc is not called unless the type in either targetitem or altitems is matched in `/datum/objective/steal/check_completion()`). I decided that since the current framework restricts us to only having a set range of items that we may as well be safe and check the var that references the "stored" AI, which works well enough. ## Why It's Good For The Game  Very cool! Fixes tgstation#72205. Almost certainly an oversight, because if you create an AI that is lawed to obey you regardless of anything in order to serve as your modsuit buddy... it's just a pain and completely un-intuitive to have to pop it out of the modsuit just so you can get the epic greentext. ## Changelog 🆑 fix: After over a year of continuous research, the Syndicate have finally managed to crack Nanotrasen's Protocol for transferring AIs from an intelliCard into a MODsuit, and vice-versa in order to extract the valuable AI in a method fit-for-sale. In short: The "Steal a Functional AI" objective will work if the "captured" AI is in a MODsuit. /🆑 commit 47f6583 Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Date: Tue Jan 24 02:04:24 2023 -0800 Ensures the unit test zone is fully lit (tgstation#72879) ## About The Pull Request This is required for view() checks to work as we expect, and is the typical state of the game The only reason things like the strippable test functioned is because we had tests that were improperly New()ing turfs instead of using changeturf Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> commit 11a94e8 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Tue Jan 24 22:56:43 2023 +1300 Automatic changelog for PR tgstation#72874 [ci skip] commit 7366625 Author: Cenrus <31044876+Cenrus@users.noreply.github.com> Date: Tue Jan 24 09:54:48 2023 +0000 Removes drag slowdown from Harvester mob (tgstation#72874) ## About The Pull Request Quick one liner to make NarSie's harvesters ignore the movement speed penalty when dragging corpses. ## Why It's Good For The Game Removes some tedium from the fun little minigame at the (bad) end of cult rounds ## Changelog 🆑 balance: Harvesters are now not affected by drag slowdown. /🆑 Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> commit 45c809b Author: Paxilmaniac <82386923+Paxilmaniac@users.noreply.github.com> Date: Tue Jan 24 04:18:12 2023 -0500 Documents all of the variables on /obj/item/reagent_containers (tgstation#72854) ## About The Pull Request I noticed a bunch of these variables weren't documented, and I know more or less what they all do, so woe documentation be upon ye. ## Why It's Good For The Game Better for future coders to understand wtf is going on inside of reagent containers ## Changelog These changes are not player facing commit c60f32b Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Tue Jan 24 22:17:13 2023 +1300 Automatic changelog for PR tgstation#72802 [ci skip] commit 78a5e90 Author: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Date: Tue Jan 24 14:46:30 2023 +0530 Rapid Wiring Device(RWD) (tgstation#72802) ## About The Pull Request Just a big roll of cable(7 stacks worth of cable) you carry around it has the following features 1. Dual wield it and just walk across plating to lay new cable. Make sure you wear insulated gloves 2. If you just have it in one of your hands it can pick up any stray cable pieces lying around 3. Right click on it to dispense a custom amount of cable 4. Refill with cable 5. Alt click to change cable layer 6. Available in autolathe & engineering protolathe round start https://user-images.githubusercontent.com/110812394/213224959-f393e849-2e0a-4314-ab0e-c10924cf8fce.mp4 ## Why It's Good For The Game 1. Clean up cable pieces bitten by rats and lay fresh cable in maintenance very quickly. 2. For big construction projects. Carrying one big roll of 7 stacks of cable is much more storage efficient than carrying 7 separate stacks individually. 3. For wiring Solars very quickly Also, I'm pretty sure something like this exists in real life so why not. It's just the rapid pipe cleaner but for cables. ## Changelog 🆑 add: Rapid wiring device imageadd: Sprite for RWD /🆑 commit cc1e5c0 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Tue Jan 24 22:14:35 2023 +1300 Automatic changelog for PR tgstation#72703 [ci skip] commit 088a93a Author: lessthanthree <83487515+lessthnthree@users.noreply.github.com> Date: Tue Jan 24 01:14:09 2023 -0800 Layering: Fixes wires and pipes on lattice catwalk, glass floor [NO GBP] (tgstation#72703) ## About The Pull Request - Fixes tgstation#72894 - Fixes layering for wiring and disposal pipes on lattice-based catwalk. (Goes on top.) Wiring and pipes on floor-based catwalk. (Goes underneath.) - Glass floor shifted to show wires/pipe underneath it. - Moves tram plaque to the game plane, layered underneath tossed objects. ## Why It's Good For The Game Wiring the solars looks weird with the wrong layering. ## Changelog 🆑 LT3 fix: Wires and pipes again rest on top of lattice catwalk /🆑 commit 18b041b Author: Zephyr <12817816+ZephyrTFA@users.noreply.github.com> Date: Tue Jan 24 01:22:24 2023 -0500 Add logging for manually changing your targeted zone (tgstation#72814) ## About The Pull Request See title. Surgery hud is exempt from this. ## Why It's Good For The Game Requested by @Mothblocks ## Changelog Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com> commit ac4bec4 Author: Changelogs <action@github.com> Date: Tue Jan 24 00:21:36 2023 +0000 Automatic changelog compile [ci skip] commit 44b18f2 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Tue Jan 24 10:32:45 2023 +1300 Automatic changelog for PR tgstation#72780 [ci skip] commit 9a9d5bc Author: Wallem <66052067+Wallemations@users.noreply.github.com> Date: Mon Jan 23 16:32:25 2023 -0500 Adds the Mississippi Queen, a new drink (tgstation#72780) ## About The Pull Request Adds the infamous Mississippi Queen, a drink so spicy it'll make you start seeing things.  ## Why It's Good For The Game  ## Changelog 🆑 add: Bartenders can now mix up the Mississippi Queen for those willing to take the plunge. /🆑 commit 5cf97e2 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Tue Jan 24 08:36:29 2023 +1300 Automatic changelog for PR tgstation#72883 [ci skip] commit 4271da6 Author: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Date: Tue Jan 24 01:05:56 2023 +0530 Light Replacer Fixes & clean up (tgstation#72883) ## About The Pull Request Fixes tgstation#72877 - Bluespace light replacer can only fix lights & turfs containing lights in its line of sight - No more spam beaming turfs which has no light sources - Code clean up i.e early returns ## Changelog 🆑 fix: bluespace light replacer from fixing lights/turfs containing lights not in its line of sight fix: beaming any turf even those not containing lights from causing lag /🆑 Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> commit 8476503 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Tue Jan 24 08:04:39 2023 +1300 Automatic changelog for PR tgstation#72851 [ci skip] commit b4cfbcf Author: Mey-Ha-Zah <tomboxallghss@gmail.com> Date: Mon Jan 23 14:01:18 2023 -0500 Adds a Burn Medkit to Mining Vendor (tgstation#72851) Adds a burn medkit to the mining vendor. Since burn damage is slightly harder to deal with on lavaland, I've made it price slightly higher than the brute medkit. commit eb6be2b Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Tue Jan 24 05:48:42 2023 +1300 Automatic changelog for PR tgstation#72870 [ci skip] commit fd66e3d Author: Inari-Whitebear <inari_whitebear@fastmail.jp> Date: Mon Jan 23 17:48:19 2023 +0100 Fix tape recorder recording null messages (fixes tgstation#72858) (tgstation#72870) ## About The Pull Request Fixes tgstation#72858 Tape recorder was using `message` instead of `raw_message` in the `Hear` callback: `/obj/item/taperecorder/Hear(message, atom/movable/speaker, message_langs, raw_message, radio_freq, spans, list/message_mods = list(), message_range)` Other instances of the callback being used seem to use `raw_message`. Additionally, `living_say` as well as `say` call `Hear` with `message` being just always being `null`. Changed tape recorder to use `raw_message` as well ## Why It's Good For The Game Tape recorders work! ## Changelog 🆑 fix: Tape recorders are not deaf anymore /🆑 commit 2d293ce Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Tue Jan 24 03:09:54 2023 +1300 Automatic changelog for PR tgstation#72638 [ci skip] commit bedf896 Author: Tim <timothymtorres@gmail.com> Date: Mon Jan 23 08:09:34 2023 -0600 Chisel and Statue Improvements (tgstation#72638) ## About The Pull Request Resolves tgstation#72607 Resolves tgstation#65701 Chisels and statues had quite a few bugs and they lacked any kind of feedback system to inform the user on it's proper usage. My improvements do the following: - Chisels now give balloon alerts when selecting a target, cancelling, or sculpting - Chisels used on carving blocks that were interrupted will now continue - Fixed abstract statues not letting people use the radial menu - Fixed chisel targets to have no range requirement (so you can use binoculars, cameras, etc.) - Refactor a lot of the chisel and statue code to be more robust - Add sculpting sounds when chisels are used on carving blocks ## Why It's Good For The Game Less bugs and now people can now sculpt easier. ## Changelog 🆑 soundadd: Chisels now make sculpting sounds when used on carving blocks qol: Chisels now give balloon alerts when selecting a target, cancelling, or sculpting qol: Chisels used on carving blocks that were interrupted will now continue fix: Fix chisel targets to have no range requirement (so you can use binoculars, cameras, etc.) fix: Fix standard mineral blocks (uranium, diamond, plasma, etc.) not letting people use the radial menu to craft abstract statues properly. This does not work with custom mineral blocks. (pizza, glass, etc.) code: Change chisel and statue code to be more readable /🆑 Co-authored-by: Time-Green <timkoster1@hotmail.com> commit 4c50e64 Author: Time-Green <timkoster1@hotmail.com> Date: Mon Jan 23 14:20:48 2023 +0100 Merge skew mondays second merge skew (tgstation#72908) This tgstation#72799 skewed with one of the AI PRs MERGE SKEW MONDAYSSSSS Shit also just shouldnt register signals in a getter Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> commit 925a88f Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Tue Jan 24 00:53:48 2023 +1300 Automatic changelog for PR tgstation#72893 [ci skip] commit c2f6a44 Author: Bloop <vinylspiders@gmail.com> Date: Mon Jan 23 06:53:28 2023 -0500 Fixes toilet bongs, and fixes a serious bug in the crafting system (tgstation#72893) ## About The Pull Request The PR everyone has been waiting for...fixed toilet bong crafting. Now you can craft them just as before using the new crafting system.  In attempting to fix this I encountered one of the gnarliest, nastiest, meanest and most infuriatingly difficult to debug bugs I have come across so far. And it's existed for as long as the crafting system has, but due to unique circumstances it has been allowed to go unnoticed this whole time. Technical details below. Full list of changes here: - crafting recipes can now contain structures as part of their requirements - removed deprecated var 'additional_req_tex' and changed text to use the 'steps' list instead so they actually show in the gui - toilet bongs are now passable terrain like normal toilets are - fixed an atrocious bug with crafting that was by pure coincidence not causing any problems - this bug would prevent any recipes that did not contain a material from deleting properly - this bug would also cause any recipes that are supposed to use but not consume machinery to consume them regardless --- Basically, the bug that took me hours upon hours of debugging and head-scratching to find is this: from crafting.dm: ``` main_loop: for(var/path_key in requirements) amt = R.reqs[path_key] || R.machinery[path_key] if(!amt)//since machinery can have 0 aka CRAFTING_MACHINERY_USE - i.e. use it, don't consume it! continue main_loop ``` specifically this line: `amt = R.reqs[path_key] || R.machinery[path_key] ` The culprit ended up being that if you do machinery[path_key] on an empty list, it can lead to very unexpected behavior (see: EXITING THE FUNCTION without actually doing anything). I spent so much time thinking that item deletion wasn't working because amt was being set to 0, false, or null perhaps when no, it wasn't that. The function was just exiting out even before the (!amt) check due to the atrocities committed by someone before me. Setting amt = `R.reqs[path_key] || R.machinery[path_key]` on the other hand always evaluates to a positive integer (either the successfully retrieved reqs amt, or a 1 from the OR expression). It was only by coincidence that the code did what it was supposed to, because: 1) Every single recipe has R_reqs, so the first part will never cause the function-exiting failure because the list is never empty. 2) As for the second part of the expression, there are no recipes that make use of CRAFTING_MACHINERY_USE, so the fact that machinery[path_key] was never actually being accessed and thus set to a var (which is what causes the function to exit) didn't matter. So these two things together have basically allowed a really bad bug to go unnoticed this whole time. I only noticed it because when trying to add a third part to the expression it just did not work at all how you would expect. The solution is rather simply to add a check like so: ``` main_loop: for(var/path_key in requirements) amt = R.reqs?[path_key] || R.machinery?[path_key] if(!amt)//since machinery can have 0 aka CRAFTING_MACHINERY_USE - i.e. use it, don't consume it! continue main_loop ``` Fixes Skyrat-SS13/Skyrat-tg#18732 . ## Why It's Good For The Game Fixes a bug with crafting that would inevitably torment someone else as soon as they tried to add the right kind of recipe, if that hasn't already happened by now. <details> <summary>Toilet bongs are back baby!!</summary>  </details> ## Changelog 🆑 fix: toilet bongs crafting recipes fix: fixed crafting itself refactor: cleaned up some old code in the recipes file, added support for structures in recipes /🆑 commit 9b8c119 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Tue Jan 24 00:08:02 2023 +1300 Automatic changelog for PR tgstation#72733 [ci skip] commit e014283 Author: Tim <timothymtorres@gmail.com> Date: Mon Jan 23 05:07:32 2023 -0600 Fix ordance bomb site being a safe teleport area after surviving the heretic minigame (tgstation#72733) ## About The Pull Request Fixes tgstation#72732 Ordance bomb site was considered a safe location to teleport to after the heretic shadow minigame. This was obviously a really bad idea, due to it being in the vacuum of space on top of a person being put to sleep for a minute before having to wakeup. ## Why It's Good For The Game No more instadeath after surviving the heretic minigame. ## Changelog 🆑 fix: Fix ordance bomb site being a safe teleport area after surviving the heretic minigame /🆑 commit ad6f301 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Tue Jan 24 00:06:30 2023 +1300 Automatic changelog for PR tgstation#72748 [ci skip] commit 9c9ca88 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Tue Jan 24 00:06:24 2023 +1300 Automatic changelog for PR tgstation#72754 [ci skip] commit 33eeae4 Author: BlueMemesauce <47338680+BlueMemesauce@users.noreply.github.com> Date: Mon Jan 23 06:05:51 2023 -0500 Automatically adds access requirement to description of supply crates (tgstation#72748) ## About The Pull Request 1. automatically adds access requirement to description of every supply crate 2. also adds access_view to the automatic system, which previously was not visible ## Why It's Good For The Game 1. better code 2. now you can see what access you need to privately purchase a crate from the supply console. ## Changelog 🆑 code: The access requirements at the end of supply crate descriptions are now automatically generated fix: Supply console now tells you what access each crate needs to be privately purchased /🆑 commit 9610295 Author: SuperSlayer <91609255+SuperSlayer0@users.noreply.github.com> Date: Mon Jan 23 13:02:14 2023 +0200 Fixes high frequency blade ignoring pacifism trait (tgstation#72754) ## About The Pull Request Fixes being able to slash mobs with wielded high frequency blades while having pacifism trait. ## Why It's Good For The Game Bugs are bad ## Changelog 🆑 fix: Wielded high frequency blades no longer ignore pacifism /🆑 commit a134572 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 23:59:06 2023 +1300 Automatic changelog for PR tgstation#72783 [ci skip] commit 88f59f9 Author: YakumoChen <king_yoshi42@yahoo.com> Date: Mon Jan 23 10:58:44 2023 +0000 Two new official posters (tgstation#72783) ## About The Pull Request Adds two new official posters to the game.  One poster teaches the crew about common 'kill words' they can use to defeat enemy agents, the other teaches the crew to keep corporate secrets where they belong: in the company. You wouldn't download a gun, right? ## Why It's Good For The Game These feel like thematically appropriate additions you might see on a corporate-created poster, and are good references to space stations past, and our favorite copyright memes. ## Changelog 🆑 imageadd: Two new corporate themed posters. /🆑 commit 8be9c59 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 23:47:56 2023 +1300 Automatic changelog for PR tgstation#72791 [ci skip] commit c50038b Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 23:41:11 2023 +1300 Automatic changelog for PR tgstation#72809 [ci skip] commit 73bc626 Author: PotatoMasher <33107541+Potato-Masher@users.noreply.github.com> Date: Mon Jan 23 05:37:11 2023 -0500 Fixes disguised morph movespeed bug (tgstation#72791) ## About The Pull Request Morph is described as this in the antag panel: "While morphed, you move faster, but are unable to attack creatures or eat anything." This is how it has worked as long as I have played, but at somepoint in the past this was broken. I was able to track down the source of this issue easier with admin powers, finally back to squash my own bug report. ## Why It's Good For The Game Fixes tgstation#61693 ## Changelog 🆑 fix: Morphs now properly move faster when disguised rather than slowing down. /🆑 commit 92e29db Author: san7890 <the@san7890.com> Date: Mon Jan 23 03:35:56 2023 -0700 Fixes Weird Circle-Fill Exceeding Bounds on Tram Console (tgstation#72809) ## About The Pull Request Hey there, do you spot the issue here?  I'm not sure when this cropped up, but it appears to have been recently since it really irritated me when I first saw it. After a bit of toying around with the UI, I dropped both the height/width variables of the "fill" into the circle (the icon itself has thick enough boundaries to where it doesn't seem weird), as well as excising the `mt` variable, as any value I threw into it would always have some weirdness. Please do tell me if I shouldn't have axed it, but I don't really see any ill effect (and quite the opposite actually). ## Why It's Good For The Game  It's not as frustrating to look at anymore! Hopefully this isn't some sort of weird localized issue, but I much prefer these results. ## Changelog 🆑 fix: Nanotrasen has pushed an update to their Transit System Consoles, which just makes sure the buttons look visually appropriate. /🆑 (i doubt players would notice though) commit c0ed47f Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 23:33:33 2023 +1300 Automatic changelog for PR tgstation#72799 [ci skip] commit 98f6e67 Author: jimmyl <70376633+mc-oofert@users.noreply.github.com> Date: Mon Jan 23 11:33:08 2023 +0100 Fixes monkey humans having their AI turned on when revived (and having a client) (tgstation#72799) ## About The Pull Request Stops on_stat_changed turning on AI with a client makes monkey humans not wack ## Why It's Good For The Game fixes tgstation#72432 ## Changelog 🆑 fix: Monkey Humans no longer have their AI turned on upon revival /🆑 commit a580ec0 Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Date: Mon Jan 23 02:31:44 2023 -0800 Prevents cutout icon generation from triggering lazyloading (tgstation#72880) ## About The Pull Request It's dumb, and causes runtimes because we don't like maploading in atom initialize for other stupid reasons Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> commit 937eec7 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 23:31:19 2023 +1300 Automatic changelog for PR tgstation#72816 [ci skip] commit 5f8a648 Author: SuperSlayer <91609255+SuperSlayer0@users.noreply.github.com> Date: Mon Jan 23 12:30:58 2023 +0200 Replaces random() with prob() in lavaland elite code (tgstation#72816) ## About The Pull Request Replaces random() proc with prob() in herald and goliath broodmother code ## Why It's Good For The Game Using prob() proc tooks less space and also it is more readable ## Changelog 🆑 code: Replaced some random() procs in lavaland elite code with prob() procs /🆑 commit 7893193 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 23:30:04 2023 +1300 Automatic changelog for PR tgstation#72819 [ci skip] commit ff86d2f Author: lessthanthree <83487515+lessthnthree@users.noreply.github.com> Date: Mon Jan 23 02:29:42 2023 -0800 Lowers firedoor loop volume (tgstation#72819) ## About The Pull Request Reduces the volume of the firedoor alarm loop ## Why It's Good For The Game It's loud, especially when they double up. On those shifts where it's running constantly, it can get on your nerves. ## Changelog 🆑 LT3 qol: Reduced volume of firedoor alarm sound loop /🆑 commit 948fa58 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 23:26:15 2023 +1300 Automatic changelog for PR tgstation#72833 [ci skip] commit 4ba5bbb Author: san7890 <the@san7890.com> Date: Mon Jan 23 03:25:56 2023 -0700 You can no longer pull out pH Indicator Strips from across the room (COOL GIF INSIDE) (tgstation#72833) ## About The Pull Request Basically, everytime you clicked and dragged the pH Indicator Booklet using mouse_drop behavior, it would give you one of the strips it had. Neat behavior, right? However, this worked at any range.  ## Why It's Good For The Game  this can not possibly be real. we need to nerf this overpowered exploit. chemist powergamers must kneel. ## Changelog 🆑 fix: Spacemen with a clear lack of genetics powers can no longer bend space and time to pull out pH indicator strips. /🆑 thank you to kelly harshman for telling me about this. sorry i had to kill off the parlor trick but the gif was too cool. commit 2f78783 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 23:25:01 2023 +1300 Automatic changelog for PR tgstation#72878 [ci skip] commit 5631d88 Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Mon Jan 23 02:24:41 2023 -0800 Fix name of greek cucumber and attack verbs (tgstation#72878) 🆑 spellcheck: Cucumber greek is now Greek cucumber spellcheck: Fixed attack verbs on the greek cucumber /🆑 commit 6f9b5ea Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 23:21:09 2023 +1300 Automatic changelog for PR tgstation#72829 [ci skip] commit dfcee89 Author: FelixRuin <31424899+FelixRuin@users.noreply.github.com> Date: Mon Jan 23 13:20:49 2023 +0300 monophobia blind fix (tgstation#72829) ## About The Pull Request Doll with monophobia and blindness dont die from being "alone" while someone in 1 tile radius. ## Why It's Good For The Game maybe if blind and with monophobia die from heart attack while he in the crowd its funny, but too inescapable situation. ## Changelog 🆑 Winter Schock fix: Blind doll with monophobia dont get stress while someone in 1 tile range /🆑 commit 82fada1 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 23:19:07 2023 +1300 Automatic changelog for PR tgstation#72866 [ci skip] commit ae26e9f Author: Zephyr <12817816+ZephyrTFA@users.noreply.github.com> Date: Mon Jan 23 05:18:46 2023 -0500 You can see and fix short circuits in mechs again (tgstation#72866) ## About The Pull Request Mechs had the ability to short circuit, but lacked the logic to display and repair that. Resolves tgstation#72835 ## Why It's Good For The Game ## Changelog 🆑 fix: NanoTrasen Engineering has identified and resolved an issue with MechOS that prevented diagnostics for internal shorting /🆑 Signed-off-by: GitHub <noreply@github.com> commit b819011 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 23:04:33 2023 +1300 Automatic changelog for PR tgstation#72864 [ci skip] commit 056f696 Author: Bloop <vinylspiders@gmail.com> Date: Mon Jan 23 05:04:13 2023 -0500 Fixes petri dish smartfridges not being constructable (tgstation#72864) ## About The Pull Request Fixes Skyrat-SS13/Skyrat-tg#16951 ## Why It's Good For The Game Now screwdriving the circuit board will allow you to make petri dish smartfridges just like all the rest. ## Changelog 🆑 fix: fixed a bug where petri dish smartfridges could not be constructed from a circuit board /🆑 commit 8ae4fb9 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 22:48:05 2023 +1300 Automatic changelog for PR tgstation#72592 [ci skip] commit 19536d9 Author: SuperSlayer <91609255+SuperSlayer0@users.noreply.github.com> Date: Mon Jan 23 11:47:44 2023 +0200 Fixes monkey cultists being unable to invoke runes (tgstation#72592) ## About The Pull Request Fixes monkey cultists being unable to invoke runes by making the rune attack_paw proc return attack_hand proc. Fixes tgstation#72020 ## Why It's Good For The Game Fixes a bug, bugs are bad. ## Changelog 🆑 fix: Monkey cultists are now able to invoke cult runes /🆑 commit 23e057c Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 22:45:49 2023 +1300 Automatic changelog for PR tgstation#72856 [ci skip] commit 57e88e6 Author: tattle <66640614+dragomagol@users.noreply.github.com> Date: Mon Jan 23 01:45:27 2023 -0800 Crafting fireaxe cabinets, mech removal cabinets, and mirrors (tgstation#72856) ## About The Pull Request Breaking down tgstation#72371 because it's... unreasonably large. So this PR splits the crafting recipe file, and adds 3 new recipes for fireaxe cabinets, mech removal cabinets, and mirrors. ## Why It's Good For The Game Wallening compliance, and more of me on my shit breaking down long files. ## Changelog 🆑 Tattle qol: fireaxe cabinets, mech removal cabinets, and mirrors can now all be crafted /🆑 Co-authored-by: tattle <article.disaster@gmail.com> commit e408c9a Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 22:34:46 2023 +1300 Automatic changelog for PR tgstation#72865 [ci skip] commit 76569cb Author: Profakos <profakos@gmail.com> Date: Mon Jan 23 10:34:09 2023 +0100 Package delivery sorter fix, autodocs (tgstation#72865) ## About The Pull Request On some maps, there is a special disposal sorting pipe, which checks if the `tomail` var of a disposal holder. However, this has been only be set on the parent disposal object. The delivery chute and the disposal bin overrode this behaviour without a parent call. I have elected to remove the two identical overrides, and move their contents to the parent, while also swapping out the `1` to the correct sorting define of the same value. I have also updated the disposal holder object merging proc. I have also autodocced proc and var definiton in the files I have touched. ## Why It's Good For The Game Now once again, the wrapper sorter objects will detect wrapped packages, and on maps that support them, will be redirected to the mail outlet chute (along with any other item in the same holder object as usual), instead of the trash outlet chute.  ## Changelog 🆑 fix: Bundles of disposal packages that contain a wrapped parcel will be now successfully redirected by the wrapping sorters /🆑 commit ef910bc Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 22:31:24 2023 +1300 Automatic changelog for PR tgstation#72853 [ci skip] commit aa1c945 Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Date: Mon Jan 23 09:30:24 2023 +0000 Fixes hacked autolathes and limbgrowers (tgstation#72853) ## About The Pull Request In my old PR I made a change to how hacked designs worked, however I later changed it so the code would look cleaner, unaware that this actually broke them. This fixes both machines, allowing them to once again print things, hacked or not. ## Why It's Good For The Game Closes tgstation#72760 Closes tgstation#72806 Closes tgstation#72823 ## Changelog 🆑 fix: Hacked autolathes and Limbgrowers can now properly print things again. /🆑 commit 2e8dfb4 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 22:29:53 2023 +1300 Automatic changelog for PR tgstation#72861 [ci skip] commit fd48108 Author: tattle <66640614+dragomagol@users.noreply.github.com> Date: Mon Jan 23 01:29:31 2023 -0800 Crafting urinals, noticeboards, and pod controllers (tgstation#72861) ## About The Pull Request Breaking down tgstation#72371 because it's... unreasonably large. So this PR adds recipes for urinals and noticeboards, and a circuit for pod computers. The pod computers don't work, but you can certainly remove them without smacking them like an animal until they fall to pieces. ## Why It's Good For The Game Wallening compliance. ## Changelog 🆑 Tattle qol: urinals and noticeboards can be handcrafted qol: pod computers can be deconstructed /🆑 Co-authored-by: tattle <article.disaster@gmail.com> commit 4ae3295 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 21:06:46 2023 +1300 Automatic changelog for PR tgstation#72859 [ci skip] commit d74ae43 Author: tattle <66640614+dragomagol@users.noreply.github.com> Date: Mon Jan 23 00:06:20 2023 -0800 Crafting light switches, request consoles, telescreens, and ticket machines (tgstation#72859) ## About The Pull Request Breaking down tgstation#72371 because it's... unreasonably large. So this PR adds recipes for light switches, request consoles, telescreens, and ticket machines. Ticket machine frame by Kryson. You can't print all of the telescreens, like the head of staff ones, but the general department ones can be printed in their respective departments. ## Why It's Good For The Game Wallening compliance, and more of me on my shit breaking down long files. ## Changelog 🆑 Tattle, Kryson qol: light switches, request consoles, telescreens, and ticket machines can now all be printed from lathes /🆑 Co-authored-by: tattle <article.disaster@gmail.com> commit 4c1b8a5 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 18:11:33 2023 +1300 Automatic changelog for PR tgstation#72867 [ci skip] commit 949de30 Author: Wallem <66052067+Wallemations@users.noreply.github.com> Date: Mon Jan 23 00:11:14 2023 -0500 Lowers the price of Kheiral Cuffs to 750 points (tgstation#72867) I've gotten some critique on the cuffs saying that for a tool mostly for new players who might be more prone to dying in lavaland, they're far too expensive, and I'd have to agree. For a much lower price you could easily get far more equipment that instead of just being useful if you die, would _prevent_ you from dying, and you'd still have points to spare. Not to mention the fact that they don't always work, as you might get gibbed by a megafauna or something like that, which would turn off the cuff. Taking all of this into account, a far lower price seems fair to me. commit b0a6336 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 15:28:02 2023 +1300 Automatic changelog for PR tgstation#72811 [ci skip] commit 2bd2cb6 Author: lessthanthree <83487515+lessthnthree@users.noreply.github.com> Date: Sun Jan 22 18:27:35 2023 -0800 Exempts horrible goose from tram hit counter (tgstation#72811) Tram hitting the goose increments the hit counter, this fixes it so mobs without clients don't increase the Tram's hit counter. commit eebd820 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 15:23:11 2023 +1300 Automatic changelog for PR tgstation#72546 [ci skip] commit 5052fa3 Author: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com> Date: Sun Jan 22 21:22:45 2023 -0500 Fixes Cooking Menu Bluescreen when the user's species has TRAIT_NOHUNGER (tgstation#72546) It bluescreened because it was expecting the `diet` variable to always be an associative list (or dictionaries, or whatever JavaScript/TypeScript calls them), when the proc that would return a species' diet could also return `null` if the species had `TRAIT_NOHUNGER`. This simply makes it so it skips checking the diet for the menu to be opened. commit 4941881 Author: AnturK <AnturK@users.noreply.github.com> Date: Mon Jan 23 01:49:08 2023 +0100 Fixes lazy loading antag maps locking world start (tgstation#72800) So the core issue here is antag datums are also created during preference spritesheet generation and when first opening admin panels. This could happen before mapping subsystem initialized and is ready for lazy loading. If this didn't actually lock the whole ss initialization it would also mean they are always loaded. I'll leave finding proper early load points for someone else if they're are necessary but New isn't it. commit 4ad83bc Author: Changelogs <action@github.com> Date: Mon Jan 23 00:20:06 2023 +0000 Automatic changelog compile [ci skip] commit eddce4c Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 11:56:32 2023 +1300 Automatic changelog for PR tgstation#72824 [ci skip] commit d0a907f Author: SMOSMOSMOSMOSMO <95004236+SmoSmoSmoSmok@users.noreply.github.com> Date: Mon Jan 23 00:55:44 2023 +0200 adds a search bar in the pda messenger (tgstation#72824) u can now search for players in the messenger by typing their name or their job commit c4eee3b Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 11:38:48 2023 +1300 Automatic changelog for PR tgstation#72831 [ci skip] commit fc7c5c2 Author: san7890 <the@san7890.com> Date: Sun Jan 22 15:38:26 2023 -0700 Fixes Deep Frier Runtime on Deconstruct (tgstation#72831) ## About The Pull Request Via https://tgstation13.org/parsed-logs/sybil/data/logs/2023/01/20/round-198547/runtime.condensed.txt ```txt The following runtime has occurred 1 time(s). runtime error: Cannot execute null.forceMove(). proc name: deconstruct (/obj/machinery/deepfryer/deconstruct) source file: deep_fryer.dm,65 usr: null src: the deep fryer (/obj/machinery/deepfryer) src.loc: space (143,123,2) (/turf/open/space) ``` The frying var being null is the default state of this machinery. Shouldn't runtime out of deconstruct() for something so silly. Let's just check against it. ## Why It's Good For The Game LET ME DECONSTRUCT THE DEEPFRIER ARRRRRGHHH ## Changelog 🆑 fix: Deconstructing deep friers should now work properly. /🆑 commit 9beb09a Author: san7890 <the@san7890.com> Date: Sun Jan 22 15:00:16 2023 -0700 Adds Lint Against Non-TXT UpdatePaths Scripts (tgstation#72785) Prevents Regression Found In tgstation#72779 (someone putting an UpdatePaths script that doesn't end in .txt through) from happening again. commit 2956541 Author: orange man <61334995+comfyorange@users.noreply.github.com> Date: Mon Jan 23 10:52:23 2023 +1300 Automatic changelog for PR tgstation#72808 [ci skip]
|
I would ask three things: First, that you remove the new character limit on crime names; it's way too short. Second, that you please remove the "quality of life" change of automatically setting suspects to arrest. There are several reasons you might not want someone set to arrest automatically when you put in a crime; perhaps you only want them set to suspected, perhaps you are filling it in retroactively after already having arrested them, etc. And finally, PLEASE get the bugs under control. Particularly the rampant visual glitches with SecHUDs; sometimes it's either not showing arrest status at all, or sometimes it IS showing arrest status; except when it's set to "none", in which case the last status set beforehand is still visible (i.e. they still appear to be "arrest" even though it is now set to "none"). This second bug seems to be the most recent one. |
|
the name portion is intentional, literally why have a description section which is 1024 characters when you could just type the entire crime into the name. the box says "BRIEF OVERVIEW". the name has the chance to clip on the rapsheet printout and the collapsibles of multiple UIs
|
|
Thanks for working on the bugs. I'd still like to ask that you remove the change of setting people automatically to arrest; like I stated before there are several perfectly good reasons you could be putting in a crime and not want someone set to arrest automatically. As for the name thing, I understand having a limit at all but I just think it's quite short. Sometimes you want to write something like "Suspected of [x]", like just on a recent round I was trying to put something like "suspected of putting up syndie posters" which I don't think is really too long for a name. |
|
wb vandalism also does this illustrate the problem titles are staying character limited if you want to write about a player without marking them for arrest, make a security note (or just one-click them back off arrest) |
|
My point on the automatically setting to arrest thing is that it's not really a quality of life change. It just adds something you have to remember whenever you touch the security records to avoid accidentally setting someone to arrest; which I've already seen happen. |
Jolly-66
added a commit
to TaleStation/TaleStation
that referenced
this pull request
Jan 28, 2023
Original PR: tgstation/tgstation#72725 ----- ## About The Pull Request I have attempted or otherwise started this project at least 4 times. I am sick of it being on my calendar. The code needs it. I need it. - This makes crew records a proper datum rather than assigning properties record.fields. - General, medical, and security records are merged. - Did some slight refactoring here and there for things that looked obvious. - Wanted states are now defined (and you can suspect someone through sechud) - pAI (unrelated but annoying) had some poorly named exported types that i made more specific - Job icons are moved back to the JS side (I wanted to get icons for initial rank without passing trim) <details> <summary>previews</summary> Editable fields & security console  Medical records  Look and feel of the more current version  </details> ## Why It's Good For The Game TGUI'd some of the worst UIs in the game. Creating new records is made much simpler. Manifest_inject is made readable. Probably bug fixes ## Changelog :cl: refactor: Crew records have been refactored. refactor: Medical records -> TGUI refactor: Security records -> TGUI refactor: Warrants console -> TGUI qol: Players are now alerted when their fines are paid off. qol: Cleaned up sec hud examination text. qol: Adding and deleting crimes is easier. qol: Writing crimes in the console sets players to arrest. qol: You can now mark someone as a suspect through sec hud. /:cl: --------- Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Co-authored-by: Jolly-66 <70232195+Jolly-66@users.noreply.github.com>
san7890
pushed a commit
that referenced
this pull request
Mar 14, 2023
…rds (#73882) ## About The Pull Request These changes re-implement the functionality for Physical and Mental Statuses, which used to be present in Medical Records (visible via medical filing cabinents, medical records consoles, and MED-HUDs). These Physical/Mental statuses can once again be updated through examining a crewmember (while wearing a Med-HUD), or through the new TGUI interface for medical records consoles. ## Why It's Good For The Game Primarily, this resolves the bugs mentioned in [Issue #73477](#73477), and restores functionality which appears to have been accidentally removed via [PR #72725](#72725). Additionally, the re-implementation of these statuses allows for more in-depth medical RP (and bureaucracy), especially in regards to the Psychiatrist role and managing crewmember sanity. ## Changelog :cl: fix: Re-implements physical and mental statuses in crewmember medical records. fix: Re-implements changing a crewmember's physical/mental status via a Med-HUD. /:cl: Edit: Image of the new TGUI buttons which now handle Physical/Mental statuses.  Closes #73477
Jolly-66
added a commit
to TaleStation/TaleStation
that referenced
this pull request
Mar 14, 2023
…rewmember Medical Records (#4875) Original PR: tgstation/tgstation#73882 ----- ## About The Pull Request These changes re-implement the functionality for Physical and Mental Statuses, which used to be present in Medical Records (visible via medical filing cabinents, medical records consoles, and MED-HUDs). These Physical/Mental statuses can once again be updated through examining a crewmember (while wearing a Med-HUD), or through the new TGUI interface for medical records consoles. ## Why It's Good For The Game Primarily, this resolves the bugs mentioned in [Issue #73477](tgstation/tgstation#73477), and restores functionality which appears to have been accidentally removed via [PR #72725](tgstation/tgstation#72725). Additionally, the re-implementation of these statuses allows for more in-depth medical RP (and bureaucracy), especially in regards to the Psychiatrist role and managing crewmember sanity. ## Changelog :cl: fix: Re-implements physical and mental statuses in crewmember medical records. fix: Re-implements changing a crewmember's physical/mental status via a Med-HUD. /:cl: Edit: Image of the new TGUI buttons which now handle Physical/Mental statuses.  Closes #73477 --------- Co-authored-by: Antonio Tosti <5588048+atosti@users.noreply.github.com> Co-authored-by: Jolly <70232195+Jolly-66@users.noreply.github.com>
scriptis
pushed a commit
to scriptis/tgstation
that referenced
this pull request
Apr 1, 2023
…rds (tgstation#73882) ## About The Pull Request These changes re-implement the functionality for Physical and Mental Statuses, which used to be present in Medical Records (visible via medical filing cabinents, medical records consoles, and MED-HUDs). These Physical/Mental statuses can once again be updated through examining a crewmember (while wearing a Med-HUD), or through the new TGUI interface for medical records consoles. ## Why It's Good For The Game Primarily, this resolves the bugs mentioned in [Issue tgstation#73477](tgstation#73477), and restores functionality which appears to have been accidentally removed via [PR tgstation#72725](tgstation#72725). Additionally, the re-implementation of these statuses allows for more in-depth medical RP (and bureaucracy), especially in regards to the Psychiatrist role and managing crewmember sanity. ## Changelog :cl: fix: Re-implements physical and mental statuses in crewmember medical records. fix: Re-implements changing a crewmember's physical/mental status via a Med-HUD. /:cl: Edit: Image of the new TGUI buttons which now handle Physical/Mental statuses.  Closes tgstation#73477
Ghommie
pushed a commit
that referenced
this pull request
Feb 28, 2024
## About The Pull Request This PR fixes a bug which disables the AI hologram's ability to copy the appearance of crew members. Fixes #78403 The bug was caused by developer error in PR #72725 when the typepath `/datum/record/crew` was used to access `GLOB.manifest.locked`, which is a list of `/datum/record/locked`. To fix the bug I replaced the erroneous typepath with `/datum/record/locked`. ## Why It's Good For The Game This PR fixes the broken feature that used to allow the AI to select from the crew records to set its hologram's appearance.   ## Changelog :cl: A.C.M.O. fix: Fixed the AI hologram's ability to copy the appearance of crew members. /:cl:
larentoun
pushed a commit
to larentoun/tgstation
that referenced
this pull request
Mar 1, 2024
## About The Pull Request This PR fixes a bug which disables the AI hologram's ability to copy the appearance of crew members. Fixes tgstation#78403 The bug was caused by developer error in PR tgstation#72725 when the typepath `/datum/record/crew` was used to access `GLOB.manifest.locked`, which is a list of `/datum/record/locked`. To fix the bug I replaced the erroneous typepath with `/datum/record/locked`. ## Why It's Good For The Game This PR fixes the broken feature that used to allow the AI to select from the crew records to set its hologram's appearance.   ## Changelog :cl: A.C.M.O. fix: Fixed the AI hologram's ability to copy the appearance of crew members. /:cl:
larentoun
pushed a commit
to larentoun/tgstation
that referenced
this pull request
Mar 1, 2024
## About The Pull Request This PR fixes a bug which disables the AI hologram's ability to copy the appearance of crew members. Fixes tgstation#78403 The bug was caused by developer error in PR tgstation#72725 when the typepath `/datum/record/crew` was used to access `GLOB.manifest.locked`, which is a list of `/datum/record/locked`. To fix the bug I replaced the erroneous typepath with `/datum/record/locked`. ## Why It's Good For The Game This PR fixes the broken feature that used to allow the AI to select from the crew records to set its hologram's appearance.   ## Changelog :cl: A.C.M.O. fix: Fixed the AI hologram's ability to copy the appearance of crew members. /:cl:
larentoun
pushed a commit
to ss220club/Bandastation
that referenced
this pull request
Mar 1, 2024
## About The Pull Request This PR fixes a bug which disables the AI hologram's ability to copy the appearance of crew members. Fixes tgstation#78403 The bug was caused by developer error in PR tgstation#72725 when the typepath `/datum/record/crew` was used to access `GLOB.manifest.locked`, which is a list of `/datum/record/locked`. To fix the bug I replaced the erroneous typepath with `/datum/record/locked`. ## Why It's Good For The Game This PR fixes the broken feature that used to allow the AI to select from the crew records to set its hologram's appearance.   ## Changelog :cl: A.C.M.O. fix: Fixed the AI hologram's ability to copy the appearance of crew members. /:cl:
larentoun
pushed a commit
to ss220club/Bandastation
that referenced
this pull request
Mar 1, 2024
## About The Pull Request This PR fixes a bug which disables the AI hologram's ability to copy the appearance of crew members. Fixes tgstation#78403 The bug was caused by developer error in PR tgstation#72725 when the typepath `/datum/record/crew` was used to access `GLOB.manifest.locked`, which is a list of `/datum/record/locked`. To fix the bug I replaced the erroneous typepath with `/datum/record/locked`. ## Why It's Good For The Game This PR fixes the broken feature that used to allow the AI to select from the crew records to set its hologram's appearance.   ## Changelog :cl: A.C.M.O. fix: Fixed the AI hologram's ability to copy the appearance of crew members. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
I have attempted or otherwise started this project at least 4 times. I am sick of it being on my calendar. The code needs it. I need it.
previews
Editable fields & security console
Medical records
Look and feel of the more current version
Why It's Good For The Game
TGUI'd some of the worst UIs in the game.
Creating new records is made much simpler.
Manifest_inject is made readable.
Probably bug fixes
Changelog
🆑
refactor: Crew records have been refactored.
refactor: Medical records -> TGUI
refactor: Security records -> TGUI
refactor: Warrants console -> TGUI
qol: Players are now alerted when their fines are paid off.
qol: Cleaned up sec hud examination text.
qol: Adding and deleting crimes is easier.
qol: Writing crimes in the console sets players to arrest.
qol: You can now mark someone as a suspect through sec hud.
/:cl: