Add auto restart feature #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restart Layer brush feature and create a new CaptureService if display settings is changed. This commit also fix Exceptions when capture area goes beyond layer display resolution boundaries. I created a feature as it appear to be the cleaner way to do this but not 100% sure if i am correct.
|
Hey, the PR is still a draft and being worked on by DarthAffe. He'll probably want to fix this in his screen capture DLL which isn't part of the plugin code |
|
No need to close this already! He may want to merge it :) |
Oops ok. |
added 2 commits
May 16, 2021 11:23
|
I have manually incorporated some of these changes alongside my own, thanks 👍🏻 |
|
Nice, I am more comfortable with your code that with mine XD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add:
Ability to autorestart theLayer Brush and create a new CaptureService. I used a Feature to handle the Display Setting change event. Don’t know if there is a better way.
This PR fixes #60 #61
This commit also fix several exceptions that ocurrs when capture area goes beyond layer display resolution boundaries.
Know bugs:
Ambilight layer brush feature will result disabled if display settings is changed while Artemis Editor is opened. Still better than profile and layer brush hang up on display setting changed. Work ok with editor closed.
Notes: