Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Paginated Responses #22

Merged
merged 3 commits into from
Mar 20, 2024
Merged

API: Paginated Responses #22

merged 3 commits into from
Mar 20, 2024

Conversation

Arthi-chaud
Copy link
Owner

No description provided.

@Arthi-chaud Arthi-chaud added the api About the API label Mar 19, 2024
@Arthi-chaud Arthi-chaud self-assigned this Mar 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 51.28205% with 133 lines in your changes are missing coverage. Please review.

Project coverage is 74.98%. Comparing base (8440b7a) to head (3f7b490).

Files Patch % Lines
api/api/src/services/extra.rs 0.00% 30 Missing ⚠️
api/api/src/services/package.rs 0.00% 28 Missing ⚠️
api/api/src/services/file.rs 0.00% 17 Missing ⚠️
api/api/src/controllers/packages.rs 16.66% 10 Missing ⚠️
api/api/src/controllers/extras.rs 25.00% 9 Missing ⚠️
api/api/src/controllers/files.rs 22.22% 7 Missing ⚠️
api/api/src/error_handling.rs 0.00% 7 Missing ⚠️
api/api/src/dto/extra.rs 0.00% 6 Missing ⚠️
api/api/src/dto/movie.rs 0.00% 6 Missing ⚠️
api/api/src/dto/package.rs 0.00% 6 Missing ⚠️
... and 4 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   79.38%   74.98%   -4.41%     
==========================================
  Files          30       31       +1     
  Lines        1237     1495     +258     
==========================================
+ Hits          982     1121     +139     
- Misses        255      374     +119     
Flag Coverage Δ
api 74.98% <51.28%> (-4.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arthi-chaud Arthi-chaud marked this pull request as ready for review March 20, 2024 19:44
@Arthi-chaud Arthi-chaud merged commit a602fb6 into main Mar 20, 2024
6 checks passed
@Arthi-chaud Arthi-chaud deleted the api/pagination branch March 20, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api About the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants