Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Basic Items Filtering #41

Merged
merged 10 commits into from
Mar 24, 2024
Merged

API: Basic Items Filtering #41

merged 10 commits into from
Mar 24, 2024

Conversation

Arthi-chaud
Copy link
Owner

@Arthi-chaud Arthi-chaud commented Mar 23, 2024

Closes #24

@Arthi-chaud Arthi-chaud added the api About the API label Mar 23, 2024
@Arthi-chaud Arthi-chaud self-assigned this Mar 23, 2024
@Arthi-chaud Arthi-chaud marked this pull request as draft March 23, 2024 20:57
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 91.60305% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 83.43%. Comparing base (1089118) to head (e1fe294).

Files Patch % Lines
api/api/src/error_handling.rs 0.00% 7 Missing ⚠️
api/api/src/services/artist.rs 95.23% 1 Missing ⚠️
api/api/src/services/extra.rs 93.75% 1 Missing ⚠️
api/api/src/services/file.rs 88.88% 1 Missing ⚠️
api/api/src/services/package.rs 88.88% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   75.55%   83.43%   +7.88%     
==========================================
  Files          32       32              
  Lines        1542     1624      +82     
==========================================
+ Hits         1165     1355     +190     
+ Misses        377      269     -108     
Flag Coverage Δ
api 83.43% <91.60%> (+7.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arthi-chaud Arthi-chaud marked this pull request as ready for review March 24, 2024 08:43
@Arthi-chaud Arthi-chaud merged commit e99aa08 into main Mar 24, 2024
11 checks passed
@Arthi-chaud Arthi-chaud deleted the api/filters branch March 24, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api About the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: Filter Items
2 participants