Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the url of notes, and tags which start with # #10

Closed
wants to merge 1 commit into from
Closed

Fixing the url of notes, and tags which start with # #10

wants to merge 1 commit into from

Conversation

yomli
Copy link
Contributor

@yomli yomli commented Apr 17, 2018

Fixing two issues :

  1. URL of notes are displayed as text (?someID) by Twitter and don't link to the website.
  2. Tags that are already hashtags are displayed like this: ##hastag.

@yomli
Copy link
Contributor Author

yomli commented Apr 18, 2018

Actually, @kalvn has some cool code in his/her shaarli2mastodon, I suggest we use that instead, it's way cleaner than mine.

Check my /feature/microblog branch, if it sounds good to you I can pull that instead.

@ArthurHoaro
Copy link
Owner

Go ahead, it looks fine, thank you. Note that I'll be out for a few days so I'll review it next week.

@yomli
Copy link
Contributor Author

yomli commented Apr 21, 2018

Ok I'll do that, thanks a lot.

@yomli yomli closed this Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants