Shutting down via the window X (or any other signal) doesn't allow for clean exit

[hippietim]

When the framerwork enters the Loop, it tales over signal handlers. This would be fine if it handled them by alerting the main process loop to exit. Instead it calls some cleanup code and exits from the exception thread. We've got COM initialization and objects created on the main thread that we'd like to be able to cleanup.

[ArthurSonzogni]

FTXUI insert itself as a signal handler, but does call back the previously defined signal handler at the end. So existing signal handler should continue to work without conflict with FTXUI.

I need a signal handler, in order to properly cleanup the terminal state when existing FTXUI. Goal is not to let the user with unusable terminal.

What would you like to see as API for FTXUI to help you with this?

[ArthurSonzogni]

Hey @hippietim,

I landed a few patches. Could you confirm your problem has been fixed or bring some suggestions?

[MichaelGoulding]

std::raise(0); causes an abort on Windows.

This comes from the line:
OnExit(0);
in ScreenInteractive::Loop

[MichaelGoulding]

---

Microsoft Visual C++ Runtime Library

Debug Assertion Failed!

Program:
File: minkernel\crts\ucrt\src\appcrt\misc\signal.cpp
Line: 456

Expression: ("Invalid signal or error", 0)

For information on how your program can cause an assertion
failure, see the Visual C++ documentation on asserts.

(Press Retry to debug the application)

---

Abort Retry Ignore

[ArthurSonzogni]

Thanks @MichaelGoulding ! This should be fixed now.

[hippietim]

The issue for us is that if we exit the process from the signal thread, we have no way of executing on the main thread again which is where we must do COM cleanup.