Testssuite fails to build: it can't find googletest

[yurivict]

===>  Testing for ftxui-3.0.0.69
-- clang-tidy not found.
CMake Error at cmake/ftxui_test.cmake:18 (add_subdirectory):
  add_subdirectory given source
  "/usr/ports/devel/ftxui/work/FTXUI-3.0.0-69-g90dfcee/_deps/googletest-src"
  which is not an existing directory.
Call Stack (most recent call first):
  CMakeLists.txt:149 (include)


CMake Error at cmake/ftxui_benchmark.cmake:13 (add_subdirectory):
  add_subdirectory given source
  "/usr/ports/devel/ftxui/work/FTXUI-3.0.0-69-g90dfcee/_deps/googlebenchmark-src"
  which is not an existing directory.
Call Stack (most recent call first):
  cmake/ftxui_test.cmake:83 (include)
  CMakeLists.txt:149 (include)


-- Configuring incomplete, errors occurred!

googletest doesn't get fetched, and it doesn't use the pre-installed googletest either.

Version: 3.0.0-69-g90dfcee
clang-14
FreeBSD 13.1

[ArthurSonzogni]

googletest are fetched for you. No problem with this library.

The problem is that you enabled the option:
FTXUI_CLANG_TIDY

And you don't have clang tidy installed.

[ArthurSonzogni]

I should probably check for clang tidy and add a better error message to explain what happened.

[yurivict]

No, I didn't enable FTXUI_CLANG_TIDY.

[ArthurSonzogni]

Okay. Then, I will take a look more closely. Thanks for reporting this!

[arrowd]

@yurivict This might has something to do with the fact that our cmake.mk always passes -DFETCHCONTENT_FULLY_DISCONNECTED:BOOL=ON in CMAKE_ARGS.

[yurivict]

It should be possible to build tests with pre-installed googletest.

[arrowd]

Yes, sure, I'm just guessing why @ArthurSonzogni may not seen this before.

[yurivict]

I see.

[ArthurSonzogni]

It should be possible to build tests with pre-installed googletest.

Note that:

• gtest from packages does not come with GTestConfig.cmake to find the library.
• New versions of CMake provide it, but it means I would have to drop support for developers using older cmake version. The first LTS ubuntu release with the required cmake version is the 22.04 one. It might be a little bit too early today.
• The official docs suggest using FetchContent.

This answer might change the tradeoff we are willing to make: Why do you need to build tests and can't use cmake fetchcontent?

[yurivict]

gtest from packages does not come with GTestConfig.cmake to find the library.

Yes it does:

$ pkg info -l googletest | grep GTestConfig
	/usr/local/lib/cmake/GTest/GTestConfig.cmake
	/usr/local/lib/cmake/GTest/GTestConfigVersion.cmake

It can be made optional to use externally installed GTest.

[ArthurSonzogni]

Not on my distribution unfortunately:
https://packages.ubuntu.com/jammy/all/googletest/filelist

If you want, I can add optional support, but I won't be able to test locally. I will make a patch and let you confirm it worked.

[ArthurSonzogni]

@yurivict / @arrowd
Could you please confirm this fixes: #551

(I can't test it locally myself, because the ubuntu package manager do not provide the proper cmake finder)