Feature: Dropdown options with callback #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/component/dropdown.cpp
Outdated
| @@ -30,12 +30,12 @@ int main() { | |||
|
|
|||
| auto layout = Container::Vertical({ | |||
| Container::Horizontal({ | |||
| Dropdown(&entries, &selected_1), | |||
| Dropdown(&entries, &selected_1, { .on_change = [&] { selected_3 = selected_1; } } ), // Keep in sync with selected_3. | |||
There was a problem hiding this comment.
Thanks!
Could you revert this file change?
There was a problem hiding this comment.
Sure - done 👍
| @@ -74,7 +74,7 @@ Component Radiobox(ConstStringListRef entries, | |||
| int* selected_, | |||
| RadioboxOption options = {}); | |||
|
|
|||
| Component Dropdown(ConstStringListRef entries, int* selected); | |||
| Component Dropdown(ConstStringListRef entries, int* selected, DropdownOption options = {}); | |||
There was a problem hiding this comment.
Could you format?
clang-format
|
@ArthurSonzogni Thanks for enhancing the dropdown functionality. I hope you don't mind but I saw the build error and put in a fix to correct it. Let me know if you think this is OK 👍 |
|
Thanks for your contribution to FTXUI! 👍 |
ArthurSonzogni
added a commit
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted two things on the dropdown in my application:
Can you consider this PR, please?
Thanks 👍