Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MFA Window Notification Message #46

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Conversation

Atreidae
Copy link
Contributor

Added a notification message to New-AsBuiltReport to advise users of a potential hidden window when using MFA

Description

Added a new Write-Host prompt when the $MFA variable is set, displays a message to encourage the user to look for an MFA window that may have appeared underneath the current window.

Related Issue

#45

Motivation and Context

Provides user feedback for PowerShell modules that don't launch their MFA window as Modal

How Has This Been Tested?

Tested in VsCode, PsISE and Windows Terminal against my own module.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.

Added a notification message to New-AsBuiltReport to advise users of a potential hidden window when using MFA
@Atreidae
Copy link
Contributor Author

FYI, the Contributing link in the PR template points to the GitHub Carrer page as it's a relevant link.

@tpcarman tpcarman merged commit 255227c into AsBuiltReport:dev Aug 26, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants