-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various enhancements #72
Conversation
@@ -96,6 +96,29 @@ function Get-AbrFgtFirewall { | |||
$TableParams['Caption'] = "- $($TableParams.Name)" | |||
} | |||
|
|||
# Identify and remove empty columns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What empty columns do you have ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example columns have alias/description, and if all rows have this column empty, then there's no point including it in the table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, may be add a settings for this
No info/configuration are an info :)
@@ -96,7 +96,7 @@ function Get-AbrFgtSystem { | |||
} | |||
|
|||
if ($info -and $settings -and $InfoLevel.System -ge 1) { | |||
Section -Style Heading3 'GUI Settings' { | |||
Section -Style Heading3 'Feature GUI visibility' { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change also TableParams name ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligned it closer to what it's labelled in firewall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and only to make also modification line 130 (TableParams = @{
Name = "Settings"
@@ -319,11 +481,89 @@ function Get-AbrFgtSystem { | |||
} | |||
} | |||
|
|||
# Fetch HA Configuration | |||
$haConfig = Get-FGTSystemHA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make a specific chapiter (and file) for HA ?
$OutObj = @() | ||
|
||
$OutObj = [pscustomobject]@{ | ||
"Group Name / ID / Mode" = $haConfig.'group-name'+' / '+$haConfig.'group-id'+' / '+$haConfig.mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one line by setting ? (like other)
|
||
$OutObj = [pscustomobject]@{ | ||
"Group Name / ID / Mode" = $haConfig.'group-name'+' / '+$haConfig.'group-id'+' / '+$haConfig.mode | ||
"HB Device" = $haConfig.'hbdev' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you align (indent) '=' ? (see visual code configuration for auto formatting)
Look great, i need to make some real try for look change ! May be better a PR by change i think ! |
@@ -1,6 +1,9 @@ | |||
{ | |||
"Report": { | |||
"Name": "Fortinet FortiGate As Built Report", | |||
"Assets": "Your Firewall HostNames", | |||
"ProjectRef": "Your Project Reference name and number", | |||
"ClientName": "Your Client's Name", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Client/Customer/Company name is already defined in the AsBuiltReport Core configuration JSON file.
$AsBuiltConfig.Company.FullName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tpcarman, there's a usecase for having two sets of company details, one for service provider and other for client. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like a specific use case, not a generic one which would be needed by all users? If you want to insert specific details into your reports you should be creating a custom style script.
@@ -49,11 +49,11 @@ TableStyle -Id 'Borderless' -HeaderStyle Normal -RowStyle Normal -BorderWidth 0 | |||
# Header & Footer | |||
if ($ReportConfig.Report.ShowHeaderFooter) { | |||
Header -Default { | |||
Paragraph -Style Header "$($ReportConfig.Report.Name) - v$($ReportConfig.Report.Version)" | |||
Paragraph -Style Header "$($ReportConfig.Report.ClientName) | $($ReportConfig.Report.Name) | $($ReportConfig.Report.ProjectRef)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Client/Customer/Company name is already defined in the AsBuiltReport Core configuration JSON file.
$AsBuiltConfig.Company.FullName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the header can be achieved by using a custom style script to tailor to your specific needs.
BlankLine | ||
|
||
$OutObj = @() | ||
foreach ($lincese in $licenseSummary) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo $lincese (and after also)
Added clarity to comments
@msoukhomlinov can you split change on multiple PR ? it will be more easy to review and merge ? |
@msoukhomlinov i merge majority of change (expect for split interface stuf and remove unused column) |
Added support for:
Cosmetic changes