New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spike Strip Optimization #519
Conversation
Pretty sure there should be a limit on how many can be placed. |
I think it should be optional. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure of it for actual content wise, but optimisations are good, just a few more things IMO
Perhaps have a config based limit? with something like -1 being for unlimited usage. |
I know this was from a while ago, but thoughts on klm's changes? I think its a logical step @iamprophet. |
life_spikestrip = _spikeStrip; | ||
waitUntil {isNull life_spikeStrip}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This waitUntil is needed to halt the script for the current functionality, aswell as removing the action. Another method would be to make a separate function for when the spikes are placed, running the remaining code then.
|
the issue is here |
Unknown repo so this PR will be closed. Spikes will be reviewed for 6.x. |
Resolves #212
Changes proposed in this pull request:
Optimizes all the spike strip files, also makes them universal so you can place as many as you want and pick up as many as you want.