Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike Strip Optimization #519

Closed
wants to merge 22 commits into from
Closed

Spike Strip Optimization #519

wants to merge 22 commits into from

Conversation

pr-ophet
Copy link
Contributor

@pr-ophet pr-ophet commented Dec 26, 2018

Resolves #212

Changes proposed in this pull request:

Optimizes all the spike strip files, also makes them universal so you can place as many as you want and pick up as many as you want.

  • I have tested my changes and corrected any errors found

@Leigham
Copy link
Contributor

Leigham commented Dec 26, 2018

Pretty sure there should be a limit on how many can be placed.

@pr-ophet
Copy link
Contributor Author

Pretty sure there should be a limit on how many can be placed.

I think it should be optional.

Copy link
Member

@DomT602 DomT602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure of it for actual content wise, but optimisations are good, just a few more things IMO

Altis_Life.Altis/core/actions/fn_packupSpikes.sqf Outdated Show resolved Hide resolved
Altis_Life.Altis/core/actions/fn_packupSpikes.sqf Outdated Show resolved Hide resolved
Altis_Life.Altis/core/cop/fn_spikeStripEffect.sqf Outdated Show resolved Hide resolved
Altis_Life.Altis/core/fn_setupActions.sqf Outdated Show resolved Hide resolved
Altis_Life.Altis/core/pmenu/fn_useItem.sqf Show resolved Hide resolved
life_hc/MySQL/Items/fn_spikeStrip.sqf Outdated Show resolved Hide resolved
life_hc/MySQL/Items/fn_spikeStrip.sqf Outdated Show resolved Hide resolved
life_hc/MySQL/Items/fn_spikeStrip.sqf Outdated Show resolved Hide resolved
life_server/Functions/Systems/fn_spikeStrip.sqf Outdated Show resolved Hide resolved
@klmunday
Copy link
Contributor

Perhaps have a config based limit? with something like -1 being for unlimited usage.
It's a good idea though! I can just see it being abused easily

@DomT602
Copy link
Member

DomT602 commented Apr 28, 2019

I know this was from a while ago, but thoughts on klm's changes? I think its a logical step @iamprophet.

life_spikestrip = _spikeStrip;
waitUntil {isNull life_spikeStrip};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This waitUntil is needed to halt the script for the current functionality, aswell as removing the action. Another method would be to make a separate function for when the spikes are placed, running the remaining code then.

@Edward-Bakker
Copy link
Contributor

16:01:57 Error in expression <[getPos player,["Land_Razorwire_F"],5]) params ["_spikes",objNull,[objNull]]; !i> 16:01:57 Error position: <params ["_spikes",objNull,[objNull]]; !i> 16:01:57 Error Type Object, expected Array,String
Getting this error with these changes

@Leigham
Copy link
Contributor

Leigham commented Sep 8, 2019

params ["_spikes",objNull,[objNull]];

the issue is here
should be
params [ ["_spikes", objNull, [objNull]] ];

@DomT602
Copy link
Member

DomT602 commented Dec 31, 2019

Unknown repo so this PR will be closed. Spikes will be reviewed for 6.x.

@DomT602 DomT602 closed this Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants