fix: cleanse behavior

[Arufonsu]

Refactors and fix cleanse status effect behavior so it will now:

• Properly dispel currently active "unfriendly" Statuses and DoTs - also skips itself from being dispelled.
• Prevent/block "unfriendly" Statuses and DoTs while active over time.
• Should resolve bug: cleanse behavior #1812

Preview:

2023-05-11.15-52-08.mp4

[lodicolo]

This PR just doesn't make any sense. Why are other statuses being dispelled in the constructor for a DoT effect...? The cleanse handling in the constructor was to prevent adding a new DoT.

[Arufonsu]

The cleanse handling in the constructor was to prevent adding a new DoT

Because DoTs cast statuses and well, now cleanse not only prevents unfriendly spells/debuffs but also cleans up the active ones

[lodicolo]

The cleanse handling in the constructor was to prevent adding a new DoT

Because DoTs cast statuses and well, now cleanse not only prevents unfriendly spells/debuffs but also cleans up the active ones

tl;dr: I do not disagree with cleaning up existing statuses that are incompatible with Cleanse, but the existing statuses should be cleaned up when the Cleanse is added, not in the constructor for a DoT later on.

Yeah but my point was that in the effect handler that added the cleanse effect in the first place everything should have been cleaned up. The DoT constructor should just "abort" if it can't be added, but it shouldn't clean up a mess that should have already been cleaned up. Otherwise none of those statuses would get cleaned up unless the DoT is added, what if a DoT is never added on the player until after the cleanse expires? Then the other statuses would just be on the player when they shouldn't be.