Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canonical and Alternate link #569

Merged
merged 4 commits into from
Aug 20, 2018
Merged

Add canonical and Alternate link #569

merged 4 commits into from
Aug 20, 2018

Conversation

ChristianGiupponi
Copy link
Contributor

This commit add canonical and alternate links for pages in each language.
Sorry for the first 2 commit, it was a mistake, the second just revert the first, the 3rd is correct

@nWidart
Copy link
Member

nWidart commented Aug 1, 2018

Hello & thank you for the contribution!

I'm not seeing where you send the data to the view.

You assign the variable with $alternate = $this->getAlternateMetaData($page); but not sending it to the view in the compact( call.

@ChristianGiupponi
Copy link
Contributor Author

Hi @nWidart you're right, I did a mess with this pull request, I have send another with the fix.
I'm exploring the cms to send more updates

@ChristianGiupponi
Copy link
Contributor Author

@nWidart did you see the update?

@nWidart
Copy link
Member

nWidart commented Aug 20, 2018

Sorry for the late reply.

Thank you!

@nWidart nWidart merged commit 0562bc8 into AsgardCms:3.0 Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants