Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vercel deployment #195

Merged
merged 4 commits into from
Apr 30, 2023
Merged

Vercel deployment #195

merged 4 commits into from
Apr 30, 2023

Conversation

fabianocouto
Copy link
Contributor

@fabianocouto fabianocouto commented Apr 29, 2023

Description

It just creates a vercel.json to deploy the project on Vercel.

Live preview on Vercel

Ashutosh's github activity graph

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@fabianocouto fabianocouto changed the title Deploy on Vercel Vercel deployment Apr 29, 2023
@Ashutosh00710 Ashutosh00710 self-requested a review April 29, 2023 14:12
Copy link
Owner

@Ashutosh00710 Ashutosh00710 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fabianocouto, thank you for your pull request. I have reviewed your PR and I have a suggestion. Could you please add instructions for Vercel deployment using the Vercel deployment button in the README.md file? This will make it easier for users to deploy the project with just one click. Thank you for your contribution 🚀

@Ashutosh00710 Ashutosh00710 added documentation Improvements or additions to documentation enhancement New feature or request dev-ops labels Apr 29, 2023
@fabianocouto
Copy link
Contributor Author

fabianocouto commented Apr 30, 2023

Hi @fabianocouto, thank you for your pull request. I have reviewed your PR and I have a suggestion. Could you please add instructions for Vercel deployment using the Vercel deployment button in the README.md file? This will make it easier for users to deploy the project with just one click. Thank you for your contribution rocket

Hi, @Ashutosh00710 !
Just to let you know that the instructions were included in the readme as requested. ;)
https://github.com/fabianocouto/readme-activity-graph#deploy-on-your-own-vercel-instance

Copy link
Owner

@Ashutosh00710 Ashutosh00710 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes and everything looks good to me. I am merging it to the main branch. @fabianocouto , Thank you for your valuable contribution. 🚀

@Ashutosh00710 Ashutosh00710 merged commit cca2def into Ashutosh00710:main Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-ops documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants