Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty language files and copy script #69

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

altrisi
Copy link
Contributor

@altrisi altrisi commented Jul 23, 2023

Minecraft already defaults to English (en_us) if the translation key has no translation. Therefore having copies of the language file is unnecessary, makes the file size larger (though not the greatest contributor), makes it more difficult to see what is and isn't translated and makes it easy to forget to move changes on en_us to other files.

This PR removes the unnecessary lang files (checked contents were equals and there's been no PRs for them) and the copy script (that was actually being packaged in the jar too although never used from it).

@AsoDesu
Copy link
Owner

AsoDesu commented Jul 23, 2023

I don't know how i didn't know this
This looks good to me 👍
Thank you :D

@AsoDesu AsoDesu merged commit 800bce9 into AsoDesu:main Jul 23, 2023
1 check passed
@altrisi altrisi deleted the no-dupe-langs branch July 24, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants