rip out configure-aspen.py #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadwhitacre
changed the title
chadwhitacre
changed the title
chadwhitacre
force-pushed
the
no-more-config-scripts
branch
from
c37ab3e
to
fbb1285
Compare
chadwhitacre
force-pushed
the
no-more-config-scripts
branch
from
fbb1285
to
09e7328
Compare
|
Rebased on master. |
|
Next step on this is to fix up the test suite.
|
chadwhitacre
force-pushed
the
no-more-config-scripts
branch
from
09e7328
to
bf55436
Compare
|
Rebased on master. |
Closed
|
Is it already gone? gratipay/inside.gratipay.com#263 (comment) What is the replacement? |
|
I don't believe it's already gone, but the replacement is to make a plain ol' Python module. |
|
@whit537 ok, I've checked that it is imported, but I still don't why the stacktrace? gratipay/inside.gratipay.com#263 (comment) |
I ended up just configuring harness.client.website inline in the tests. I think that makes sense, right?
configure-aspen.py was the default for configuration_scripts, but it was possible to specify others.
chadwhitacre
force-pushed
the
no-more-config-scripts
branch
from
7641bb7
to
7693dd9
Compare
|
Ready for review, @techtonik @pjz et al. |
|
(Also, re-re-rebased on master.) |
| <li><code><a href="/configure-aspen.py/">configure-aspen.py</a></code></li> | ||
| <li><code><a href="/mime.types/">mime.types</a></code></li> | ||
| </ul> | ||
| <p>Aspen will read the <code><a href="/mime.types/">mime.types</a></code> file |
|
Need a note in Changelog.md about the removal and intended replacement. |
chadwhitacre
added a commit
that referenced
this pull request
Jul 1, 2015
|
Good catch. Done in 579261b. |
|
!m @whit537 |
Changaco
pushed a commit
that referenced
this pull request
Mar 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #373.