Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean i18n file #144

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Update Korean i18n file #144

merged 1 commit into from
Feb 27, 2018

Conversation

miname
Copy link
Contributor

@miname miname commented Feb 26, 2018

Updated Korean i18n file to the latest.

@dzc34 dzc34 added the i18n label Feb 26, 2018
@dzc34 dzc34 merged commit 1cd3c7d into Asqatasun:develop Feb 27, 2018
@miname miname deleted the i18n-korean branch February 27, 2018 03:37
@dzc34
Copy link
Member

dzc34 commented Feb 27, 2018

Great. Thanks @miname for your contributing!
it's now merged into the development branch.

why do you delete the lang="en" attribute around "Contrast-Finder"?
In fact, it is used by screen readers (such as JAWS or NVDA) to vocalize "Contrast-Finder" in English.

@miname
Copy link
Contributor Author

miname commented Feb 27, 2018

Oh, that was my mistake using the diff tool.
Sorry for the inconvenience.
I'll fix it now.

@dzc34
Copy link
Member

dzc34 commented Feb 28, 2018

fixed with PR #145 by @miname

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants