Skip to content

Commit

Permalink
fix: Support optional parameters in d.ts generation (#1665)
Browse files Browse the repository at this point in the history
  • Loading branch information
dcodeIO committed Feb 3, 2021
1 parent eb36166 commit b24925c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/definitions.ts
Expand Up @@ -459,11 +459,11 @@ export class TSDBuilder extends ExportsWalker {
sb.push("(");
var parameters = signature.parameterTypes;
var numParameters = parameters.length;
// var requiredParameters = signature.requiredParameters;
var requiredParameters = signature.requiredParameters;
for (let i = 0; i < numParameters; ++i) {
if (i) sb.push(", ");
// if (i >= requiredParameters) sb.push("optional ");
sb.push(element.getParameterName(i));
if (i >= requiredParameters) sb.push("?");
sb.push(": ");
sb.push(this.typeToString(parameters[i]));
}
Expand Down

0 comments on commit b24925c

Please sign in to comment.