Add padStart/padEnd methods. Refactor string copy, compare and repeat #171
Conversation
This reverts commit 2e17772.
std/assembly/string.ts
Outdated
| var padLen = padString.length; | ||
| if (targetLength < length || !padLen) return this; | ||
| var len = targetLength - length; | ||
| if (len > padLen) padString = padString.repeat(len / padLen + 1); |
There was a problem hiding this comment.
if len = 4, padLen = 2, this would repeat the string 4 / 2 + 1 = 3 times (I'd expect 2 times) - is that correct?
There was a problem hiding this comment.
Yes. I can improve this for case, when reminder is zero after division
std/assembly/string.ts
Outdated
| memory.copy( | ||
| changetype<usize>(out) + HEADER_SIZE + (<usize>length << 1), | ||
| changetype<usize>(padString) + HEADER_SIZE, | ||
| <usize>targetLength << 1 |
There was a problem hiding this comment.
Does this copy out of bounds? Rather <usize>len << 1 ?
std/assembly/string.ts
Outdated
| changetype<usize>(out), | ||
| changetype<usize>(padString), | ||
| padLen, | ||
| (len + padLen - 1) / padLen |
There was a problem hiding this comment.
Need replace to len/padLen + rest copy
std/assembly/internal/string.ts
Outdated
| destOffset: usize, | ||
| src: String, | ||
| length: i32, | ||
| count: i32 |
There was a problem hiding this comment.
What are length and count? Can't one be computed from the other?
There was a problem hiding this comment.
length is length of repeated source. Is better rename it to srcLenght?
EDIT. Yep can remove length after refactoring. Not needed anymore
There was a problem hiding this comment.
count is how many repeat times we want
MaxGraey
changed the title
MaxGraey
changed the title
|
Thank you! :) |
No description provided.