-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix and refactor Date #1804
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick review, and this PR looks good to me 😄
Also, shoutout to @ColinEberhardt for kicking this off! 😄 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks spot on to me - thanks @MaxGraey
@ColinEberhardt thanks! I'll merge this when node nightly build (canary) will be available |
Some post improvements and refactors for feat: implemented getters / setters and various string fns on Date #1768
Add getUTCDay
I've read the contributing guidelines