Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include env/RT in generated definitions #1901

Merged
merged 4 commits into from
Jun 12, 2021
Merged

Include env/RT in generated definitions #1901

merged 4 commits into from
Jun 12, 2021

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Jun 11, 2021

With the definitions now being in a format that can be picked up by bundlers (anticipating ESM integration) even when not using the loader, it may be useful to also declare the memory and the table, as well as exported runtime helpers.

  • memory if exported
  • table if exported
  • _start if explicit
  • __new, __pin, __unpin, __collect and __rtti_base if exported
  • __setArgumentsLength if there are exported varargs functions

Also fixes #1900

  • I've read the contributing guidelines

@dcodeIO
Copy link
Member Author

dcodeIO commented Jun 11, 2021

Test failure is v8-canary missing builds.

@dcodeIO dcodeIO requested a review from MaxGraey June 11, 2021 20:56
src/definitions.ts Outdated Show resolved Hide resolved
src/definitions.ts Outdated Show resolved Hide resolved
dcodeIO and others added 3 commits June 12, 2021 00:08
Co-authored-by: Max Graey <maxgraey@gmail.com>
Co-authored-by: Max Graey <maxgraey@gmail.com>
@dcodeIO dcodeIO merged commit 3a76daf into main Jun 12, 2021
@dcodeIO dcodeIO deleted the lldefs branch June 18, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing export set property definitions
2 participants