Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allows Simd constructors accept more than just constants #2143

Merged
merged 5 commits into from
Apr 9, 2022

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Nov 13, 2021

Before we could only accept constants due to lowering to v128.const only. In this PR simd constructions now accept variables as well. All this lower to splat or const + replace_line-s as appropriate. For example:

// mixed const and vars arguments
const v1 = f32x4(0.0, 2.0, fx, fy); // where fx, fy non-precomputed expressions
// only var arguments
const v2 = i64x2(x, y);
  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO April 9, 2022 09:32
@dcodeIO dcodeIO merged commit 3d84f2d into AssemblyScript:main Apr 9, 2022
@dcodeIO
Copy link
Member

dcodeIO commented Apr 9, 2022

Thanks :)

@MaxGraey MaxGraey deleted the v128-from-vars branch April 9, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants