Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add diagnose when initializing field in interface #2797

Merged
merged 2 commits into from Nov 15, 2023
Merged

fix: add diagnose when initializing field in interface #2797

merged 2 commits into from Nov 15, 2023

Conversation

HerrCai0907
Copy link
Member

Fixes: #2795

CountBleck
CountBleck approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@CountBleck CountBleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/compiler/interface-with-initializer.ts Outdated Show resolved Hide resolved
@HerrCai0907 @CountBleck
Update tests/compiler/interface-with-initializer.ts
6bffe92 
Co-authored-by: CountBleck <Mr.YouKnowWhoIAm@protonmail.com>
@HerrCai0907 HerrCai0907 merged commit 4f15024 into AssemblyScript:main Nov 15, 2023
13 checks passed
@HerrCai0907 HerrCai0907 deleted the add-interface-diagnose branch November 15, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CountBleck CountBleck CountBleck approved these changes

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing diagnose for interface with initialized field
2 participants
@HerrCai0907 @CountBleck