Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XVM: replace MultiAddress with AccountId for ink! contracts #1024

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

shaunxw
Copy link
Member

@shaunxw shaunxw commented Sep 13, 2023

Pull Request Summary

Closes #1021. Please check out the issue for more details.

cc @PierreOssun

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

@shaunxw shaunxw added shibuya related to shibuya XVM Related to XVM runtime This PR/Issue is related to the topic “runtime”. labels Sep 13, 2023
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/batch/src 80% 0%
primitives/src 65% 0%
primitives/src/xcm 66% 0%
pallets/contracts-migration/src 0% 0%
pallets/xc-asset-config/src 53% 0%
precompiles/assets-erc20/src 76% 0%
precompiles/utils/src/testing 62% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/ethereum-checked/src 48% 0%
pallets/collator-selection/src 69% 0%
pallets/dapps-staking/src/pallet 85% 0%
pallets/custom-signatures/src 51% 0%
chain-extensions/dapps-staking/src 0% 0%
chain-extensions/pallet-assets/src 0% 0%
pallets/block-reward/src 85% 0%
precompiles/utils/macro/src 0% 0%
chain-extensions/types/dapps-staking/src 0% 0%
chain-extensions/types/assets/src 0% 0%
chain-extensions/xvm/src 0% 0%
pallets/dapps-staking/src 81% 0%
pallets/pallet-xcm/src 53% 0%
precompiles/sr25519/src 79% 0%
pallets/xvm/src 40% 0%
precompiles/utils/src 68% 0%
precompiles/xcm/src 84% 0%
precompiles/xvm/src 75% 0%
precompiles/dapps-staking/src 93% 0%
precompiles/substrate-ecdsa/src 78% 0%
Summary 57% (2561 / 4490) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaunxw shaunxw merged commit c6d4dfe into master Sep 14, 2023
12 of 15 checks passed
@shaunxw shaunxw deleted the xvm-wasm-contract-addr branch September 14, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya XVM Related to XVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XVM: replace MultiAddress with AccountId for ink! contracts
3 participants