Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: EVM address casing #1029

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fix: EVM address casing #1029

merged 2 commits into from
Nov 16, 2023

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Nov 15, 2023

Pull Request Summary

There is an EVM address formatting issue in account unification. Unified account EVM addresses were always displayed as lowercase

image image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Visit the preview URL for this PR (updated for commit bb593fe):

https://astar-apps--pr1029-fix-evm-account-case-aoux4zqk.web.app

(expires Wed, 22 Nov 2023 15:44:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@bobo-k2 bobo-k2 merged commit 15f4a4c into main Nov 16, 2023
6 checks passed
@bobo-k2 bobo-k2 deleted the fix/evm-account-case branch November 16, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants