Improve ask! flipper guide #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit edf5995): https://astar-docs--pr263-ashutoshvarma-feat-a-ryoulg0c.web.app (expires Tue, 21 Feb 2023 14:45:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d |
Maar-io
force-pushed
the
feature/build-revamp
branch
2 times, most recently
from
704971c
to
e1d5792
Compare
ashutoshvarma
force-pushed
the
ashutoshvarma/feat/ask-improve
branch
from
c966e5c
to
d56fb95
Compare
ashutoshvarma
force-pushed
the
ashutoshvarma/feat/ask-improve
branch
from
d56fb95
to
edf5995
Compare
andabak
reviewed
Feb 14, 2023
|
|
||
| Now we will deploy this smart contract on our testnet. | ||
|
|
||
| We will access [polkadot.js](https://polkadot.js.org/apps/) and deploy the smart contract. Select Shibuya testnet and pick `metadata.json` for “json for either ABI or .contract bundle” section and pick `flipper.opstimized.wasm` for “compiled contract WASM” section. | ||
| We will access [polkadot.js](https://polkadot.js.org/apps/) and deploy the smart contract. Select Shibuya testnet and pick `metadata.json` for “json for either ABI or .contract bundle” section and pick `flipper.optimized.wasm` for “compiled contract WASM” section. |
There was a problem hiding this comment.
I assume same issue will happen as with ink! Weight V2 issue?
There was a problem hiding this comment.
I assume same issue will happen as with ink! Weight V2 issue?
Yes
- ask! does not produce
.contractbundle, so it is not possible to deploy using Contracts-UI as it only supports contract bundle (I couldn't get it to accept wasm and metadata.json separately) - other possibility would be deploy using polkadot.js and import contract in Contract-UI to interact, but maybe that would be too much for a complete newbie? thoughts?
There was a problem hiding this comment.
we combine wasm and metadata into .contract when we generate types for it with swanky.
Maybe we can add that to compile phase so that ask! also outputs .contract when compiled using swanky.
niklabh
pushed a commit
that referenced
this pull request
Feb 17, 2023
gluneau
pushed a commit
that referenced
this pull request
Feb 21, 2023
niklabh
added a commit
that referenced
this pull request
Feb 21, 2023
* Added astar.js example to interact with WASM contract * Wiki link * Update docs/build/wasm/interact/interact.md Co-authored-by: Ashutosh Varma <ashutoshvarma11@live.com> * feat: improve ask! flipper guide (#263) * Added Chain extension (#268) * cleaned up grammar and spelling * polished language * clean up grammar and syntax * phrasing and syntax updates * phrasing and syntax updates * phrasing and syntax updates * phrasing and syntax, and update missing description * Final Edits - XCM Section * Final Edits - Integrate Toolings Section * Final Edits - Use WebAssembly (Wasm) Section * Final Edits - Use EVM section * initial reshufle evm shuffle fix broken links burn.md fix moved Intergation Tooling section back to Root due to Megan's changes fix relative links more links broken more broken links this is an empty commit test link remaning buid_environment removed underscore in folder name removing funny links liiinks remove md from link new changes by Megan * ready for review * Temporary disable of translations (i18n) so the site can be build * Fix a typo. Added nav bar shortcut. * preliminary edits to introduction and build environment sections * added banners * use user guide for account creation * add RPC info * Merged two ink! environment pages (#264) * updated links (#265) * initial reshufle evm shuffle fix broken links burn.md fix moved Intergation Tooling section back to Root due to Megan's changes fix relative links more links broken more broken links this is an empty commit test link remaning buid_environment removed underscore in folder name removing funny links liiinks remove md from link new changes by Megan ready for review preliminary edits to introduction and build environment sections Temporary disable of translations (i18n) so the site can be build Fix a typo. Added nav bar shortcut. added banners use user guide for account creation add RPC info Merged two ink! environment pages (#264) updated links (#265) * fix bad img for local network * added CE doc --------- Co-authored-by: Megan Skye Phoenix <58894568+meganskye@users.noreply.github.com> Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com> Co-authored-by: andabak <ivan@astar.network> Co-authored-by: Shunsuke Watanabe <shunsukesan.tech@gmail.com> * WASM in title * Changes as per review * Changes as per review * Wording * send transaction docs * make the Interact as a new folder * removed // If you didn't use swanky the name will be metadata.json * token name * newlines * moved below * error moved to helper * fix * Update docs/build/wasm/interact/astarjs.md Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com> * Update docs/build/wasm/interact/astarjs.md Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com> * Update docs/build/wasm/interact/astarjs.md Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com> * Update docs/build/wasm/interact/astarjs.md Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com> * heading --------- Co-authored-by: Ashutosh Varma <ashutoshvarma11@live.com> Co-authored-by: PierreOssun <35110271+PierreOssun@users.noreply.github.com> Co-authored-by: Megan Skye Phoenix <58894568+meganskye@users.noreply.github.com> Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com> Co-authored-by: andabak <ivan@astar.network> Co-authored-by: Shunsuke Watanabe <shunsukesan.tech@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I planned to add my PSP34 Guide in a new
Zero To Ask! Herosection, similar to what we have for ink! but later dropped the idea.The PSP34 Guide requires patching ask! packages (due to bugs in ask! lang) and it is not a good practice so we should wait for the fixes to be merged in ask! (I've already made PRs for the fixes in ask! repo)