-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ask! flipper guide #263
Conversation
Visit the preview URL for this PR (updated for commit edf5995): https://astar-docs--pr263-ashutoshvarma-feat-a-ryoulg0c.web.app (expires Tue, 21 Feb 2023 14:45:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d |
704971c
to
e1d5792
Compare
c966e5c
to
d56fb95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
d56fb95
to
edf5995
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 comments - not a blocker but more like nice to have
|
||
Now we will deploy this smart contract on our testnet. | ||
|
||
We will access [polkadot.js](https://polkadot.js.org/apps/) and deploy the smart contract. Select Shibuya testnet and pick `metadata.json` for “json for either ABI or .contract bundle” section and pick `flipper.opstimized.wasm` for “compiled contract WASM” section. | ||
We will access [polkadot.js](https://polkadot.js.org/apps/) and deploy the smart contract. Select Shibuya testnet and pick `metadata.json` for “json for either ABI or .contract bundle” section and pick `flipper.optimized.wasm` for “compiled contract WASM” section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume same issue will happen as with ink! Weight V2 issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume same issue will happen as with ink! Weight V2 issue?
Yes
- ask! does not produce
.contract
bundle, so it is not possible to deploy using Contracts-UI as it only supports contract bundle (I couldn't get it to accept wasm and metadata.json separately) - other possibility would be deploy using polkadot.js and import contract in Contract-UI to interact, but maybe that would be too much for a complete newbie? thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we combine wasm and metadata into .contract when we generate types for it with swanky.
Maybe we can add that to compile phase so that ask! also outputs .contract when compiled using swanky.
* Added astar.js example to interact with WASM contract * Wiki link * Update docs/build/wasm/interact/interact.md Co-authored-by: Ashutosh Varma <ashutoshvarma11@live.com> * feat: improve ask! flipper guide (#263) * Added Chain extension (#268) * cleaned up grammar and spelling * polished language * clean up grammar and syntax * phrasing and syntax updates * phrasing and syntax updates * phrasing and syntax updates * phrasing and syntax, and update missing description * Final Edits - XCM Section * Final Edits - Integrate Toolings Section * Final Edits - Use WebAssembly (Wasm) Section * Final Edits - Use EVM section * initial reshufle evm shuffle fix broken links burn.md fix moved Intergation Tooling section back to Root due to Megan's changes fix relative links more links broken more broken links this is an empty commit test link remaning buid_environment removed underscore in folder name removing funny links liiinks remove md from link new changes by Megan * ready for review * Temporary disable of translations (i18n) so the site can be build * Fix a typo. Added nav bar shortcut. * preliminary edits to introduction and build environment sections * added banners * use user guide for account creation * add RPC info * Merged two ink! environment pages (#264) * updated links (#265) * initial reshufle evm shuffle fix broken links burn.md fix moved Intergation Tooling section back to Root due to Megan's changes fix relative links more links broken more broken links this is an empty commit test link remaning buid_environment removed underscore in folder name removing funny links liiinks remove md from link new changes by Megan ready for review preliminary edits to introduction and build environment sections Temporary disable of translations (i18n) so the site can be build Fix a typo. Added nav bar shortcut. added banners use user guide for account creation add RPC info Merged two ink! environment pages (#264) updated links (#265) * fix bad img for local network * added CE doc --------- Co-authored-by: Megan Skye Phoenix <58894568+meganskye@users.noreply.github.com> Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com> Co-authored-by: andabak <ivan@astar.network> Co-authored-by: Shunsuke Watanabe <shunsukesan.tech@gmail.com> * WASM in title * Changes as per review * Changes as per review * Wording * send transaction docs * make the Interact as a new folder * removed // If you didn't use swanky the name will be metadata.json * token name * newlines * moved below * error moved to helper * fix * Update docs/build/wasm/interact/astarjs.md Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com> * Update docs/build/wasm/interact/astarjs.md Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com> * Update docs/build/wasm/interact/astarjs.md Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com> * Update docs/build/wasm/interact/astarjs.md Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com> * heading --------- Co-authored-by: Ashutosh Varma <ashutoshvarma11@live.com> Co-authored-by: PierreOssun <35110271+PierreOssun@users.noreply.github.com> Co-authored-by: Megan Skye Phoenix <58894568+meganskye@users.noreply.github.com> Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com> Co-authored-by: andabak <ivan@astar.network> Co-authored-by: Shunsuke Watanabe <shunsukesan.tech@gmail.com>
Originally I planned to add my PSP34 Guide in a new
Zero To Ask! Hero
section, similar to what we have for ink! but later dropped the idea.The PSP34 Guide requires patching ask! packages (due to bugs in ask! lang) and it is not a good practice so we should wait for the fixes to be merged in ask! (I've already made PRs for the fixes in ask! repo)