Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add filters and slits to wheels #176

Merged
merged 1 commit into from
Feb 14, 2023
Merged

add filters and slits to wheels #176

merged 1 commit into from
Feb 14, 2023

Conversation

oczoske
Copy link
Collaborator

@oczoske oczoske commented Feb 1, 2023

#175 Methods add_filter and add_slit have been created for FilterWheel and SlitWheel, along with test functions. Note that filters are replaced (rather than added) if name already exists in the filters/slits dictionaries.

@oczoske oczoske added the enhancement New feature or request label Feb 1, 2023
@oczoske oczoske linked an issue Feb 1, 2023 that may be closed by this pull request
Possibility to add filters/slits to FilterWheel/SlitWheel #175
Closed
@astronomyk astronomyk merged commit 6f48c35 into dev_master Feb 14, 2023
@oczoske oczoske deleted the oc/add_filter_slit branch March 20, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astronomyk astronomyk astronomyk approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibility to add filters/slits to FilterWheel/SlitWheel
2 participants
@oczoske @astronomyk