Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVO data because SVO is down #185

Merged
merged 1 commit into from
Mar 12, 2023
Merged

Conversation

hugobuddel
Copy link
Collaborator

See http://svo2.cab.inta-csic.es/theory/fps3/fps.php "We are having some technical problems and our services will be unavailable for some days. "

Should fix #184

See http://svo2.cab.inta-csic.es/theory/fps3/fps.php
"We are having some technical problems and our services will be unavailable for some days. "
@hugobuddel
Copy link
Collaborator Author

This PR adds many of the SVO files (at least the ones used by the test suite) to a data directory, and packages that directory within the ScopeSim package.

ScopeSim first looks in that data directory for the SVO files, and only requests them for SVO if they cannot be found.

This data directory might not be the best way to solve this problem. Nevertheless, I'm merging this now, because at the moment ScopeSim is effectively broken for new users who do not have their astropy cache filled. Plus, other PR's are now blocked, such as #187

We can discuss whether we want a better solution later.

For example, it is still worthwhile to have a test that actually tries to download a file from SVO, to check whether that works. That test could then perhaps be marked xfail or something.

@hugobuddel hugobuddel merged commit e43a9ef into dev_master Mar 12, 2023
@hugobuddel hugobuddel deleted the hb/feature/storesvodata branch May 6, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVO servers down
1 participant