Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TERCurve plot method #270

Merged

Conversation

teutoburg
Copy link
Contributor

No description provided.

@teutoburg teutoburg changed the title fix plot method Fix TERCurve plot method Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (e5c1e3d) 80.23% compared to head (45083bb) 80.21%.

Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #270      +/-   ##
==============================================
- Coverage       80.23%   80.21%   -0.02%     
==============================================
  Files             143      143              
  Lines           14808    14811       +3     
==============================================
  Hits            11881    11881              
- Misses           2927     2930       +3     
Files Changed Coverage Δ
scopesim/effects/ter_curves.py 82.44% <0.00%> (-0.64%) ⬇️

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@teutoburg teutoburg marked this pull request as ready for review September 8, 2023 15:50
Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some code smells in there, but if it gets the job done, then fine for now!

@hugobuddel hugobuddel merged commit 22a86a8 into AstarVienna:dev_master Sep 8, 2023
17 of 18 checks passed
@teutoburg teutoburg deleted the fh/actually-fix-ter-plot branch September 8, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants