Fix notebook tests #320
Merged
Fix notebook tests #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Add safe bash header - Make runnable locally
teutoburg
added
refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev_master #320 +/- ##
===========================================
Coverage 77.04% 77.04%
===========================================
Files 57 57
Lines 7705 7705
===========================================
Hits 5936 5936
Misses 1769 1769 ☔ View full report in Codecov by Sentry. |
|
I'd say this works now |
hugobuddel
reviewed
Jan 5, 2024
| @@ -1,53 +1,56 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| echo "# Running Notebooks Tests" >> $GITHUB_STEP_SUMMARY | |||
| # https://betterdev.blog/minimal-safe-bash-script-template/ | |||
| set -Eeuo pipefail | |||
There was a problem hiding this comment.
Uch, I messed this up, because I did not try to run the script without any parameters. If $1 is unset, the script breaks. See https://github.com/AstarVienna/ScopeSim_Data/actions/runs/7405748794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the notebook tests to have a single workflow actually running the notebooks, with two separate workflows requesting it with or without git cloning the IRDB repo.