-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix notebook tests #320
Merged
Merged
Fix notebook tests #320
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
22d7a62
Factor out notebook script calling
teutoburg f568caf
Remove dev_spectroscopy branch reference
teutoburg 8e207e6
Include tqdm improvements
teutoburg 380c3c2
Ignore pytest notebook warnings
teutoburg fdd0e1f
Use poetry
teutoburg b3cafca
Also use poetry for calling jupytext
teutoburg 9dd2b1e
Only find notebooks in docs (and not in clones irdb)
teutoburg 614598e
No more irdb symlinks for now
teutoburg 984f734
attempt to fix broken script
teutoburg 009885d
Fix --clone-irdb mode
hugobuddel 705e7e6
Remove redundant || exit
hugobuddel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
name: Notebooks Dispatch | ||
|
||
on: | ||
# Allows wourkflow to be called by other workflows | ||
workflow_call: | ||
inputs: | ||
clone-irdb: | ||
type: boolean | ||
description: If True, use clone of IRDB repo instead of package download. | ||
|
||
jobs: | ||
run_notebooks: | ||
strategy: | ||
matrix: | ||
# Run all operating systems, because this is the first interaction | ||
# that users have with ScopeSim / IRDB. | ||
# However, only use minimum and maximum supported Python version, | ||
# as the IRDB download often fails. | ||
# As of 2023/07/19, this test still often fails. See | ||
# https://github.com/AstarVienna/ScopeSim/issues/254 | ||
# For now, only run on one configuration, as having one green test | ||
# is more useful than 5 green and one red. The others can be enabled | ||
# once we fix the problem properly. | ||
# os: [ubuntu-latest, windows-latest, macos-latest] | ||
# python-version: ['3.8', '3.11'] | ||
os: [ubuntu-latest] | ||
python-version: ["3.11"] | ||
runs-on: ${{ matrix.os }} | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Set up Poetry | ||
uses: abatilo/actions-poetry@v2 | ||
with: | ||
poetry-version: "1.7.1" | ||
|
||
- name: Install dependencies | ||
run: | | ||
poetry install --with test --with dev --all-extras | ||
|
||
- name: Run notebooks | ||
env: | ||
TQDM_MININTERVAL: 10 | ||
CLONE: ${{ inputs.clone-irdb && '--clone-irdb' || '' }} | ||
run: ./runnotebooks.sh $CLONE --delete |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uch, I messed this up, because I did not try to run the script without any parameters. If $1 is unset, the script breaks. See https://github.com/AstarVienna/ScopeSim_Data/actions/runs/7405748794