Resolve recursive bang-strings

scopesim/effects/effects_utils.py

@@ -41,7 +41,7 @@ def combine_surface_effects(surface_effects):
     surflist_list = [eff for eff in surface_effects
                      if isinstance(eff, efs.SurfaceList)]
     surf_list = [eff for eff in surface_effects
-                 if isinstance(eff, (efs.TERCurve, efs.FilterWheel))
+                 if isinstance(eff, (efs.TERCurve, efs.FilterWheelBase))
                  and not isinstance(eff, efs.SurfaceList)]
 
     if not surflist_list:

scopesim/effects/surface_list.py

@@ -3,7 +3,7 @@
 import numpy as np
 from astropy import units as u
 
-from .ter_curves import TERCurve
+from .ter_curves import TERCurve, FilterWheelBase
 from ..optics import radiometry_utils as rad_utils
 from ..optics.surface import PoorMansSurface
 from ..utils import quantify, from_currsys, figure_factory
@@ -119,7 +119,7 @@ def is_empty(self):
     def add_surface(self, surface, name=None, position=-1, add_to_table=True):
         if name is None:
             name = surface.meta.get("name", "<unknown surface>")
-        if isinstance(surface, TERCurve):
+        if isinstance(surface, (TERCurve, FilterWheelBase)):
             ter_meta = surface.meta
             surface = surface.surface
             surface.meta.update(ter_meta)

scopesim/effects/ter_curves.py

@@ -1,5 +1,4 @@
 """Transmission, emissivity, reflection curves."""
-
 from collections.abc import Collection
 
 import numpy as np
@@ -26,6 +25,9 @@ class TERCurve(Effect):
     """
     Transmission, Emissivity, Reflection Curve.
 
+    note:: This is basically an ``Effect`` wrapper for the
+           ``SpectralSurface`` object
+
     Must contain a wavelength column, and one or more of the following:
     ``transmission``, ``emissivity``, ``reflection``.
     Additionally, in the header there
@@ -201,7 +203,12 @@ def plot(self, which="x", wavelength=None, *, axes=None, **kwargs):
         if wavelength is None:
             wunit = params["wave_unit"]
             # TODO: shouldn't need both, make sure they're equal
-            assert wunit == wave_unit
+            if wunit != wave_unit:
+                logger.warning(f"wavelength units in the meta dict of "
+                             f"{self.meta.get('name')} are inconsistent: \n"
+                             f"- wavelength_unit : {wave_unit} \n"
+                             f"- wave_unit : {wunit}")
+
             wave = np.arange(quantify(params["wave_min"], wunit).value,
                              quantify(params["wave_max"], wunit).value,
                              quantify(params["wave_bin"], wunit).value)
@@ -213,6 +220,8 @@ def plot(self, which="x", wavelength=None, *, axes=None, **kwargs):
         abbrs = {"t": "transmission", "e": "emission",
                  "r": "reflection", "x": "throughput"}
 
+        if not isinstance(axes, list):
+            axes = [axes]
         for ter, ax in zip(which, axes):
             y_name = abbrs.get(ter, "throughput")
             y = getattr(self.surface, y_name)
@@ -581,6 +590,14 @@ def apply_to(self, obj, **kwargs):
         """Use apply_to of current filter."""
         return self.current_filter.apply_to(obj, **kwargs)
 
+    @property
+    def surface(self):
+        return self.current_filter.surface
+
+    @property
+    def throughput(self):
+        return self.current_filter.throughput
+
     def fov_grid(self, which="waveset", **kwargs):
         return self.current_filter.fov_grid(which=which, **kwargs)
 

scopesim/optics/optics_manager.py

@@ -237,10 +237,20 @@ def fov_setup_effects(self):
     @property
     def surfaces_table(self):
         """Get combined surface table from effects with z_order = 100...199."""
-        if self._surfaces_table is None:
-            surface_like_effects = self.get_z_order_effects(100)
-            self._surfaces_table = combine_surface_effects(surface_like_effects)
-        return self._surfaces_table
+        from copy import deepcopy
+        sle_list = self.get_z_order_effects(100)
+        sle_list_copy = []
+        for eff in sle_list:
+            if isinstance(eff, efs.SurfaceList):
+                eff_copy = deepcopy(eff)
+                eff_copy.table = from_currsys(eff.table)
+            else:
+                # Avoid infinite recursion in Wheel effects (filter, adc)
+                eff_copy = eff
+            sle_list_copy += [eff_copy]
+
+        comb_table = combine_surface_effects(sle_list_copy)
+        return comb_table
 
     @property
     def all_effects(self):

scopesim/utils.py

@@ -863,11 +863,18 @@ def from_currsys(item):
     if isinstance(item, str) and len(item) and item.startswith("!"):
         if item in rc.__currsys__:
             item = rc.__currsys__[item]
+            if isinstance(item, str) and item.startswith("!"):
+                item = from_currsys(item)
         else:
             raise ValueError(f"{item} was not found in rc.__currsys__")
 
-    if isinstance(item, str) and item.lower() == "none":
-        item = None
+    if isinstance(item, str):
+        if item.lower() == "none":
+            item = None
+        try:
+            item = float(item)
+        except TypeError:
+            pass
 
     return item