-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve recursive bang-strings #351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev_master #351 +/- ##
==============================================
- Coverage 75.15% 75.13% -0.03%
==============================================
Files 59 59
Lines 7970 7999 +29
==============================================
+ Hits 5990 6010 +20
- Misses 1980 1989 +9 ☔ View full report in Codecov by Sentry. |
teutoburg
requested changes
Jan 23, 2024
teutoburg
requested changes
Jan 29, 2024
my bad
Co-authored-by: teutoburg <73600109+teutoburg@users.noreply.github.com>
Co-authored-by: teutoburg <73600109+teutoburg@users.noreply.github.com>
teutoburg
approved these changes
Jan 30, 2024
teutoburg
requested changes
Jan 30, 2024
b82961c
to
7ba4334
Compare
teutoburg
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit
13ac4db
(i.e.
temperature = !TEL.temperature = !ATMO.temperature = 7
)Commit
7d8e3e6
FilterWheelBase
class which enable it also be treated as aTERCurve
in the context of the plotting routines and summary table helper functions inOpticsManager
. These changes are (solely) cosmetic and shouldn't affect any of the real scopesim machinary.