Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve recursive bang-strings #351

Merged
merged 12 commits into from
Jan 31, 2024
Merged

Conversation

astronomyk
Copy link
Collaborator

Commit 13ac4db

  • Simple recursive call that (should) catch multi-level band-strings
    (i.e. temperature = !TEL.temperature = !ATMO.temperature = 7)
  • I also added a check to catch stringified floats, and turn them into floats. This is needed because when a single entry in a table column is a bang-string, and the other entries are floats, then astropy will read them all in as strings. And when the bang-string is resolved, it is reinserted as a string, rather than a float. This check solves that (I think)

Commit 7d8e3e6

  • Additions to several classes, primarily the FilterWheelBase class which enable it also be treated as a TERCurve in the context of the plotting routines and summary table helper functions in OpticsManager. These changes are (solely) cosmetic and shouldn't affect any of the real scopesim machinary.

@astronomyk astronomyk added bug Something isn't working enhancement New feature or request labels Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c4c2264) 75.15% compared to head (7ba4334) 75.13%.

Files Patch % Lines
scopesim/effects/ter_curves.py 45.45% 6 Missing ⚠️
scopesim/__init__.py 50.00% 2 Missing ⚠️
scopesim/version.py 50.00% 2 Missing ⚠️
scopesim/utils.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #351      +/-   ##
==============================================
- Coverage       75.15%   75.13%   -0.03%     
==============================================
  Files              59       59              
  Lines            7970     7999      +29     
==============================================
+ Hits             5990     6010      +20     
- Misses           1980     1989       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scopesim/optics/optics_manager.py Outdated Show resolved Hide resolved
scopesim/optics/optics_manager.py Show resolved Hide resolved
scopesim/utils.py Show resolved Hide resolved
scopesim/utils.py Outdated Show resolved Hide resolved
scopesim/effects/ter_curves.py Outdated Show resolved Hide resolved
scopesim/effects/ter_curves.py Outdated Show resolved Hide resolved
scopesim/effects/ter_curves.py Outdated Show resolved Hide resolved
@teutoburg teutoburg changed the title Kl/currsys recursive bangs Resolve recursive bang-strings Jan 23, 2024
scopesim/utils.py Outdated Show resolved Hide resolved
teutoburg and others added 3 commits January 29, 2024 13:51
Co-authored-by: teutoburg <73600109+teutoburg@users.noreply.github.com>
Co-authored-by: teutoburg <73600109+teutoburg@users.noreply.github.com>
scopesim/__init__.py Outdated Show resolved Hide resolved
scopesim/version.py Show resolved Hide resolved
@teutoburg teutoburg merged commit b20f0f8 into dev_master Jan 31, 2024
24 of 25 checks passed
@teutoburg teutoburg deleted the kl/currsys_recursive_bangs branch January 31, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants