Merge pull request #158 from AstarVienna/hb/remove38

Remove support for Python 3.8
AstarVienna · Feb 28, 2024 · e38d867 · e38d867
2 parents 913d0f3 + f394840
commit e38d867
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -22,7 +22,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
-        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
+        python-version: ['3.9', '3.10', '3.11', '3.12']
 
     steps:
       - uses: actions/checkout@v3
@@ -54,7 +54,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
-        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
+        python-version: ['3.9', '3.10', '3.11', '3.12']
 
     steps:
       - uses: actions/checkout@v3

diff --git a/irdb/badges.py b/irdb/badges.py
@@ -132,9 +132,7 @@ class MsgOnlyBadge(StrBadge):
     pattern = Template("[![](https://img.shields.io/badge/$key-$col)]()")
 
     def __init__(self, key: str, value: str):
-        # value = value.removeprefix("!")
-        # TODO: for Python 3.8 support:
-        value = value[1:]
+        value = value.removeprefix("!")
         super().__init__(key, value)
 
 

diff --git a/irdb/publish_utils.py b/irdb/publish_utils.py
@@ -7,9 +7,7 @@
 import logging
 from datetime import date
 from typing import List, Tuple, Set, Dict
-# Python 3.8 doesn't yet know these things.......
-# from collections.abc import Iterator, Iterable, Mapping
-from typing import Iterator, Iterable, Mapping
+from collections.abc import Iterator, Iterable, Mapping
 
 from more_itertools import first, last, groupby_transform