Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Python 3.8 #158

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Remove support for Python 3.8 #158

merged 2 commits into from
Feb 28, 2024

Conversation

hugobuddel
Copy link
Collaborator

No description provided.

Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You could even now remove the from typing import List, Tuple, Set, Dict stuff, because from Python 3.9 onwards, it understands the standard list, tuple, set, dict in that context. But the typing import will still work, so it's also fine to do that later 🙂

@teutoburg teutoburg added the irdb functionality Publish script, packaging, badges etc. label Feb 28, 2024
@hugobuddel
Copy link
Collaborator Author

Thanks! You could even now remove the from typing import List, Tuple, Set, Dict stuff, because from Python 3.9 onwards, it understands the standard list, tuple, set, dict in that context.

Let's do that later then. I just did an rg -. "[^0-9]3\.8[^0-9]" and cleaned up the places where you left comments.

@hugobuddel hugobuddel merged commit e38d867 into dev_master Feb 28, 2024
8 checks passed
@hugobuddel hugobuddel deleted the hb/remove38 branch February 28, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
irdb functionality Publish script, packaging, badges etc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants