[WIP] Event editor #135
Merged
[WIP] Event editor #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was annoying and probably not needed
white-axe
requested changes
Jul 2, 2024
It was just technical debt, back from when Window deduplication was by Window::name instead of Window::id
white-axe
requested changes
Jul 4, 2024
white-axe
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
N/A
Description
This reimplements (part of) the event editor, as well as the picker modals! (Switch, Variable, Graphic, etc) I added some temporary test modals into the item and actor editor to show off that they work.
There isn't any event command editor yet though- That's reserved for another PR. I'm still working out the details of the event command editor. Same goes for Undo/Redo as well.
Testing
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown -Z build-std=std,panic_abortcargo build --releasetrunk build --release