Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): don't purge go.nvim default config tables #1054

Closed

Conversation

dontmindmexdd
Copy link

Closes #1044

📑 Description

  • Remove disable_defaults flag for go.nvim

ℹ Additional Information

disable_defaults empties all of the configuration tables for go.nvim. With this flag enabled, all configurations must be set manually, or the plugin will produce an error. Please see the configuration documentation.

Copy link

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@dontmindmexdd dontmindmexdd changed the title fix(pack.go): don't purge go.nvim default config tables fix(go): don't purge go.nvim default config tables Jun 19, 2024
@dontmindmexdd
Copy link
Author

Closing because of #1059

@dontmindmexdd dontmindmexdd deleted the dev-go.nvim-config-fix branch June 21, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go pack have inccorect config
1 participant