Improve: show http code on error page

AstroProfundis · Jan 17, 2014 · acddd33 · acddd33
1 parent d707c2c
commit acddd33
Show file tree

Hide file tree

Showing 12 changed files with 20 additions and 18 deletions.
diff --git a/all.php b/all.php
@@ -19,7 +19,7 @@
 <?php
 	$statuses = $t->homeTimeline();
 	if ($statuses === false) {
-		header('location: error.php');exit();
+		header('location: error.php?code='.$t->http_code);exit();
 	}
 	$empty = count($statuses) == 0? true: false;
 	if ($empty) {
@@ -43,7 +43,7 @@
 
 	$statuses = $t->replies();
 	if ($statuses === false) {
-		header('location: error.php');exit();
+		header('location: error.php?code='.$t->http_code);exit();
 	}
 	$empty = count($statuses) == 0? true: false;
 	if ($empty) {
@@ -65,7 +65,7 @@
 
 	$messages = $t->directMessages();
 	if ($messages === false) {
-		header('location: error.php');exit();
+		header('location: error.php?code='.$t->http_code);exit();
 	}
 	$empty = count($messages) == 0? true: false;
 	if ($empty) {

diff --git a/error.php b/error.php
@@ -7,15 +7,17 @@
 <div id="login_area">
 	<div id="error">
 		<?php
-		if ( isset($_GET['t'])){ 
-			switch($_GET['t']){
+		if (isset($_GET['t'])) { 
+			switch($_GET['t']) {
 				case 1:
 				echo '<p>Fail to connect Twitter right now. Please <a href="index.php">go back</a> or <a href="logout.php">sign in</a> minutes later.</p>';
 				break;
 				default:
 				echo '<p>Ooops, an unknown error occured. Please <a href="index.php">go back</a> or <a href="logout.php">sign in</a> again.</p>';
 			}
-		} else{
+		} else if (isset($_GET['code'])) {
+			echo '<p>Ooops, an error <a href="https://dev.twitter.com/docs/error-codes-responses">'.$code.'</a> occured. Please <a href="index.php">go back</a> or <a href="logout.php">sign in</a> again.</p>';
+		} else {
 			echo '<p>Ooops, an unknown error occured. Please <a href="index.php">go back</a> or <a href="logout.php">sign in</a> again.</p>';
 		}
 		?>

diff --git a/favor.php b/favor.php
@@ -19,7 +19,7 @@
 
 	$statuses = $t->getFavorites($user_id, $since_id, $max_id);
 	if ($statuses === false) {
-		header('location: error.php');exit();
+		header('location: error.php?code='.$t->http_code);exit();
 	} 
 	$empty = count($statuses) == 0 ? true : false;
 	if ($empty) {

diff --git a/inc/sentForm.php b/inc/sentForm.php
@@ -104,7 +104,7 @@
 		$t = getTwitter();
 		$user = $t->veverify();
 		if ($user === false) {
-			header('location: error.php');exit();
+			header('location: error.php?code='.$t->http_code);exit();
 		} 
 		$empty = count($user) == 0 || !isset($user->status) || $user->status->text == '';
 		if ($empty) {

diff --git a/index.php b/index.php
@@ -37,7 +37,7 @@
 	$statuses = $t->homeTimeline($since_id, $max_id);
 	if ($statuses == false)
 	{
-		header('location: error.php');exit();
+		header('location: error.php?code='.$t->http_code);exit();
 	}
 	$count = count($statuses);
 	$empty = $count == 0 ? true : false;

diff --git a/list.php b/list.php
@@ -16,7 +16,7 @@
 		$statuses = $t->listStatus($id, $since_id, $max_id);
 		$listInfo = $t->listInfo($id);
 		if ($statuses === false) {
-			header('location: error.php');exit();
+			header('location: error.php?code='.$t->http_code);exit();
 		} 
 
 		$isFollower = $t->isFollowedList($id);

diff --git a/lists.php b/lists.php
@@ -38,7 +38,7 @@
 		$prelist = $lists->previous_cursor;
 		$lists = $lists->lists; 
 		if ($lists === false) {
-			header('location: error.php');exit();
+			header('location: error.php?code='.$t->http_code);exit();
 		} 
 
 

diff --git a/message.php b/message.php
@@ -40,7 +40,7 @@
 			$messages = $t->directMessages($since_id, $max_id);
 		}
 		if ($messages === false) {
-			header('location: error.php');exit();
+			header('location: error.php?code='.$t->http_code);exit();
 		}
 
 		$count_t = count($messages);

diff --git a/profile.php b/profile.php
@@ -17,7 +17,7 @@
 
 		$statuses = $t->userTimeline(false, $since_id, $max_id);
 		if ($statuses === false) {
-			header('location: error.php');exit();
+			header('location: error.php?code='.$t->http_code);exit();
 		} 
 		$empty = count($statuses) == 0? true: false;
 		if ($empty) {

diff --git a/replies.php b/replies.php
@@ -17,7 +17,7 @@
 
 		$statuses = $t->replies($since_id, $max_id);
 		if ($statuses === false) {
-			header('location: error.php');exit();
+			header('location: error.php?code='.$t->http_code);exit();
 		} 
 
 		$count_t = count($statuses);

diff --git a/status.php b/status.php
@@ -9,13 +9,13 @@
 		$statusid = $_GET['id'];
 		$status = $t->showStatus($statusid);
 		if (!$status) {
-			header('location: error.php');exit();
+			header('location: error.php?code='.$t->http_code);exit();
 		}
 		$user = $status->user;
 		$date = format_time($status->created_at);
 		$text = formatEntities($status->entities,$status->text);
 	} else {
-		header('location: error.php');exit();
+		header('location: error.php?code='.$t->http_code);exit();
 	}
 ?>
 

diff --git a/user.php b/user.php
@@ -11,7 +11,7 @@
 <div id="statuses" class="column round-left">
 <?php 
 	if (!loginStatus() || !isset($_GET['id'])) {
-		header('location: error.php');exit();
+		header('location: error.php?code='.$t->http_code);exit();
 	}
 
 	$t = getTwitter();
@@ -25,7 +25,7 @@
 	}
 
 	if ($statuses === false) {
-		header('location: error.php');exit;
+		header('location: error.php?code='.$t->http_code);exit;
 	}
 	if ($t->http_code == 429) {
 		$apiout = true;