WIP: Feature: Allow min and max values in any checks file to have null value
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also uses the pydantic conint type to constrain the min and max values to be greater than or equal to zero, as there is no need to have a check count be negative.
simojo
requested review from
AidanNeeson,
laurennevill,
AlishChhetri,
audreyblarr,
CalebKendra and
Finley8
|
It's worth noting that this also ships a fix where
This is, of course, the opposite of the expected behavior. See commit 682f54c for this fix. |
|
Hello @simojo, this check seems to be presenting a problem and, thus far, we've not had a team member devote the time to removing the tracking of test coverage and/or rewrite the tracking of test coverage. Your build is failing for this reason. What do you think is the best step forward? |
gkapfham
changed the title
min and max values in any checks file to have null valuemin and max values in any checks file to have null value
CalebKendra
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the json schema used in validation of checks files, and it changes the pydantic
BaseModelclass structure. See the diffs for details. This is one of two steps towards PR #59. The next step after this is to change the local checks file:.chasten/checks.yml, which will be merged after this PR is merged.