-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] ✨ StampView 및 KeyChain 변경 #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any -> [String] 변환 과정 에러 수정
AsyncswiftApp의 Environment Object 생성 -> MantabView의 StateObject로 변경
KeyChain > addItem @discardableResult 추가
MainTabView+Observed
Co-authored-by: Eunyeong Kim <unnnyong@gmail.com>
앱 백그라운드에서 불러올 때 StampView가 다시 안그려지는 버그 수정
insub4067
approved these changes
Nov 9, 2022
This was referenced Nov 9, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
각 이벤트마다 저장되던 것을 AsnycSwiftStamp이라는 Key로 [String]배열을 저장 및 불로오도록 수정하였습니다.
Stamp를 여러개 찍어도 반영될 수 있게끔 수정하였습니다.
Stamp가 지목되면 Observed에 currentIndex로 선택된 카드의 인덱스가 저장됩니다.
카드의 크기는 디바이스 세로의 좌우 패딩값(각 16)을 뺀 나머지로 계산했습니다.
Stamp의 OffsetY 지점은
카드의 크기 + 하단 패딩(16) + 카드의 순번 * 56
으로 계산되었습니다.Next Todo
스크린샷