Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PerRequestConfig #591

Closed
slandelle opened this issue Jul 4, 2014 · 1 comment
Closed

Drop PerRequestConfig #591

slandelle opened this issue Jul 4, 2014 · 1 comment
Assignees
@slandelle
Labels
Enhancement
Milestone
1.9.0

Comments

@slandelle
Copy link
Contributor

BTW, guess what, PerRequestConfig.proxyServer is never used as it's also defined directly on Request!!!
@slandelle slandelle added this to the 1.9.0 milestone Jul 4, 2014
@slandelle slandelle self-assigned this Jul 4, 2014
slandelle pushed a commit that referenced this issue Jul 4, 2014
Drop PerRequestConfig, close #591
feeb504
@slandelle
Copy link
Contributor Author

Already done one master

@slandelle slandelle mentioned this issue Jul 4, 2014
Closed
13 tasks
@pavelliu pavelliu mentioned this issue Jun 16, 2018
Closed
cs-workco pushed a commit to cs-workco/async-http-client that referenced this issue Apr 13, 2023
@Lukasa
Fix crash when receiving 2xx response before stream is complete. (Asy…
2483e08 
…ncHttpClient#591)

Motivation

It's totally acceptable for a HTTP server to respond before a request
upload has completed. If the response is an error, we should abort the
upload (and we do), but if the response is a 2xx we should probably just
finish the upload.

In this case it turns out we'll actually hit a crash when we attempt to
deliver an empty body message. his is no good!

Once that bug was fixed it revealed another: while we'd attempted to
account for this case, we hadn't tested it, and so it turns out that
shutdown would hang. As a result, I've also cleaned that up.

Modifications

- Tolerate empty circular buffers of bytes when streaming an upload.
- Notify the connection that the task is complete when we're done.

Result

Fewer crashes and hangs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slandelle slandelle

Labels
Enhancement
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
1 participant
@slandelle