Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lecture dates (for all languages), other fixes #340

Merged
merged 20 commits into from
Jun 9, 2020
Merged

Lecture dates (for all languages), other fixes #340

merged 20 commits into from
Jun 9, 2020

Conversation

jatinkhilnani
Copy link
Contributor

  • Fixed lecture dates and formats for all languages
  • Author (10-1, 10-2)
  • Redundant title (12-1)
  • Image ref & other modifications (zh: 05-2)

@jatinkhilnani jatinkhilnani mentioned this pull request May 25, 2020
Merged
@ebetica ebetica requested a review from Atcold May 26, 2020 20:00
@ebetica
Copy link
Collaborator

ebetica commented May 26, 2020

This is amazing! Thank you so much!

I wonder if we want to use dd/mm/yyyy as the date format to be readable across languages? (shouldn't block this PR)

@jatinkhilnani
Copy link
Contributor Author

I believe mon format is more readable because it does not cause the confusion of dd/mm vs mm/dd based on what the audience is used to or assumes it to be.

Atcold
Atcold requested changes Jun 5, 2020
View reviewed changes
Copy link
Owner

@Atcold Atcold left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm impressed! This PR is HUGE! Thank youuuu!

One thing I don't understand is the following:

Screenshot 2020-06-05 at 15 25 42

@jatinkhilnani jatinkhilnani requested a review from Atcold June 7, 2020 00:12
@jatinkhilnani
Copy link
Contributor Author

jatinkhilnani commented Jun 7, 2020 •
edited
Loading

Verified that this is related to PR #335 which got synced to my fork through 3bec78a. Related to flag icon changes done by @ebetica. Had an opposite effect on my end of undoing his changes, since jekyllbook submodule was modified but not synced correctly. Forced it to be in sync so that the modifications are not reverted. Please merge now.

One thing I don't understand is the following:

Screenshot 2020-06-05 at 15 25 42

jatinkhilnani
jatinkhilnani commented Jun 7, 2020
View reviewed changes
Copy link
Contributor Author

@jatinkhilnani jatinkhilnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighted change got removed after syncing the submodule. Everything looks good now.

Atcold
Atcold approved these changes Jun 9, 2020
View reviewed changes
Copy link
Owner

@Atcold Atcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@Atcold Atcold merged commit 64127cc into Atcold:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atcold Atcold Atcold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jatinkhilnani @ebetica @Atcold