Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Add lecturer, dates, and translators #336

Merged
merged 1 commit into from
May 23, 2020

Conversation

ebetica
Copy link
Collaborator

@ebetica ebetica commented May 21, 2020

Example:

image

image

I did not check whether all the authors were correct / up to date, and if somebody misspelled an annotation it won't appear.

@ebetica ebetica requested a review from Atcold May 21, 2020 19:52
@ebetica ebetica mentioned this pull request May 22, 2020
@Atcold
Copy link
Owner

Atcold commented May 23, 2020

This is great! Can we add the translated by field too?
Shall I merge this for now?

@Atcold
Copy link
Owner

Atcold commented May 23, 2020

Okay, merging, because it's too awesome!

@Atcold Atcold merged commit 4d05587 into Atcold:master May 23, 2020
@Atcold
Copy link
Owner

Atcold commented May 23, 2020

Bug! Haha.
Screenshot 2020-05-22 at 21 06 01

@Atcold
Copy link
Owner

Atcold commented May 23, 2020

Can we remove the default to Yann LeCun?
Also, if there are no authors, we shouldn't draw the line (I'm talking about the summaries page).

@ebetica ebetica deleted the chapter-labels branch May 23, 2020 21:17
@ebetica
Copy link
Collaborator Author

ebetica commented May 23, 2020

Okay - let me clarify before I start implementation:

  • No lecturer on summaries page
  • Translated By if it exists
  • Remove the emoji if there's no scribe annotations
  • What about the date? Do we date the summary pages too or not?
  • If no (Date, Translated-By, Scribe) annotations, remove the line.

@jatinkhilnani
Copy link
Contributor

Quick query: The section dates now don't seem to align with lecture date, e.g. 13-1 & 13-3 say 5-May, while 13-2 still reflects the lecture date 27-Apr. Are they being updated to reflect edits?

@ebetica
Copy link
Collaborator Author

ebetica commented May 25, 2020

@jatinkhilnani I think they should line up with lecture dates, but I guess we have not been checking them prior. I don't think we've standardized on a date format either... Maybe send in a PR if you find an error and know the real lecture date?

@jatinkhilnani
Copy link
Contributor

@ebetica One PR #340 coming right up. Have modified lecture dates and format across all languages and made some other fixes too.

Had to change the lecture dates manually across all language markdowns. I believe we can add the lecture plan to config and have it take from there, so that all markdowns remain in sync automatically even for future translations. What say?

@ebetica
Copy link
Collaborator Author

ebetica commented May 26, 2020

Are the dates consistent across languages? Should we use Chinese words instead of 3-let month abbreviations? Also - are lecturer names consistent across languages? Should we use the Chinese version of a Chinese lecturer's name on the Chinese translations, for example? It might be better to leave it as is, in order to be flexible.

@jatinkhilnani
Copy link
Contributor

Yes, the dates & lecturer names are consistent for all languages. They would be carried forward to other languages for future translations, since the en files would be used for translation. Hence, including them in the default configuration as had suggested earlier is not required for now.

If translating name & date characters, each translator would have to be consistent for each language, to do so for lecturer, contributor & translator names and corresponding dates.

@Atcold
Copy link
Owner

Atcold commented Jun 5, 2020

Okay - let me clarify before I start implementation:

  • No lecturer on summaries page
  • Remove the emoji if there's no scribe annotations

Yeah, these two are the same. Summaries do not have authors (or have too many), so I'd avoid the emoji and bottom line.

  • Translated By if it exists

Yup. We can use the 🌐 emoji. Or even the flag of the language it's been translated into. That would be sooooo cool!

  • What about the date? Do we date the summary pages too or not?

Date = when we had a given lecture. Summaries do not need dates.

  • If no (Date, Translated-By, Scribe) annotations, remove the line.

If there is no Authors field, then no line and no meta data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants