-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Add lecturer, dates, and translators #336
Conversation
This is great! Can we add the translated by field too? |
Okay, merging, because it's too awesome! |
Can we remove the default to |
Okay - let me clarify before I start implementation:
|
Quick query: The section dates now don't seem to align with lecture date, e.g. 13-1 & 13-3 say 5-May, while 13-2 still reflects the lecture date 27-Apr. Are they being updated to reflect edits? |
@jatinkhilnani I think they should line up with lecture dates, but I guess we have not been checking them prior. I don't think we've standardized on a date format either... Maybe send in a PR if you find an error and know the real lecture date? |
@ebetica One PR #340 coming right up. Have modified lecture dates and format across all languages and made some other fixes too. Had to change the lecture dates manually across all language markdowns. I believe we can add the lecture plan to config and have it take from there, so that all markdowns remain in sync automatically even for future translations. What say? |
Are the dates consistent across languages? Should we use Chinese words instead of 3-let month abbreviations? Also - are lecturer names consistent across languages? Should we use the Chinese version of a Chinese lecturer's name on the Chinese translations, for example? It might be better to leave it as is, in order to be flexible. |
Yes, the dates & lecturer names are consistent for all languages. They would be carried forward to other languages for future translations, since the If translating name & date characters, each translator would have to be consistent for each language, to do so for lecturer, contributor & translator names and corresponding dates. |
Yeah, these two are the same. Summaries do not have authors (or have too many), so I'd avoid the emoji and bottom line.
Yup. We can use the 🌐 emoji. Or even the flag of the language it's been translated into. That would be sooooo cool!
Date = when we had a given lecture. Summaries do not need dates.
If there is no |
Example:
I did not check whether all the authors were correct / up to date, and if somebody misspelled an annotation it won't appear.