Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the hinge loss equation #832

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Conversation

guydav
Copy link
Contributor

@guydav guydav commented Nov 18, 2022

Fixed a small mistake in the hinge loss equation in 11-2 -- the subtraction of the offending example's energy was outside of the max operator, where it should be inside -- see the table provided later in 11.2, or slide 19 here: https://cs.nyu.edu/~yann/talks/lecun-20041200-ebm-whistler.pdf

Copy link
Owner

@Atcold Atcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. It would be even better if we replace \max(0, …) with (…)^+.
Would you be able to do that? Otherwise, I can merge this update.

@guydav
Copy link
Contributor Author

guydav commented Dec 7, 2022

@Atcold sure thing, see the latest commit.

Copy link
Owner

@Atcold Atcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@Atcold Atcold merged commit 29e3e15 into Atcold:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants