add constructor to allow proxy configuration #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havetisyan
requested changes
Aug 30, 2023
| try { | ||
| client = new ZTSClient("http://localhost:4080/", | ||
| "invalid-proxy", "iaas.athenz", "ci", siaProvider); | ||
| fail(); |
There was a problem hiding this comment.
Can you please add test cases where
- domainName
- serviceName
- siaProvider
are null and IllegalArgumentException is thrown.
There was a problem hiding this comment.
Thank you for the feedback. I have added the tests.
Signed-off-by: Yosuke Nakada <yonakada@yahoo-corp.jp>
Signed-off-by: Yosuke Nakada <yonakada@yahoo-corp.jp>
ysknkd
force-pushed
the
feat/add-proxy-conf
branch
from
3a4f41d
to
c41b60c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a constructor to the ZTSClient for configuring a proxy.