ConcurrentModificationException on atmosphere websocket connection #1908

albertdabrowski · 2015-03-25T10:09:34Z

I'm using atmosphere-runtime version 2.3.0-RC3 and the following exception occurs after exchanging few frames over websocket. BTW, it's setup to send it in binary mode.

Message received! 1817199655410146
2015-03-23 14:51:32 WARN  TrackMessageSizeInterceptor:135 - Cannot use TrackMessageSizeInterceptor with binary write. Writing the message as it is.
2015-03-23 14:51:32 WARN  TrackMessageSizeInterceptor:135 - Cannot use TrackMessageSizeInterceptor with binary write. Writing the message as it is.
Message received! 1817199655410147
2015-03-23 14:51:32 WARN  TrackMessageSizeInterceptor:135 - Cannot use TrackMessageSizeInterceptor with binary write. Writing the message as it is.
Message received! 1817199655410148
2015-03-23 14:51:32 WARN  TrackMessageSizeInterceptor:135 - Cannot use TrackMessageSizeInterceptor with binary write. Writing the message as it is.
Message received! 1817199655410149
2015-03-23 14:51:32 WARN  TrackMessageSizeInterceptor:135 - Cannot use TrackMessageSizeInterceptor with binary write. Writing the message as it is.
Message received! 1817199655410150
2015-03-23 14:51:32 WARN  TrackMessageSizeInterceptor:135 - Cannot use TrackMessageSizeInterceptor with binary write. Writing the message as it is.
Message received! 1817199655410151
2015-03-23 14:51:32 WARN  TrackMessageSizeInterceptor:135 - Cannot use TrackMessageSizeInterceptor with binary write. Writing the message as it is.
Message received! 1817199655410152
2015-03-23 14:51:32 WARN  TrackMessageSizeInterceptor:135 - Cannot use TrackMessageSizeInterceptor with binary write. Writing the message as it is.
Message received! 1817199655410153
2015-03-23 14:51:32 WARN  TrackMessageSizeInterceptor:135 - Cannot use TrackMessageSizeInterceptor with binary write. Writing the message as it is.
Message received! 1817199655410154
2015-03-23 14:51:32 WARN  TrackMessageSizeInterceptor:135 - Cannot use TrackMessageSizeInterceptor with binary write. Writing the message as it is.
2015-03-23 14:51:32 DEBUG BridgeRuntime:682 - Exception
java.util.ConcurrentModificationException
       at java.util.HashMap$HashIterator.nextNode(HashMap.java:1429)
       at java.util.HashMap$EntryIterator.next(HashMap.java:1463)
       at java.util.HashMap$EntryIterator.next(HashMap.java:1461)
       at org.atmosphere.websocket.protocol.ProtocolUtil.attributes(ProtocolUtil.java:57)
       at org.atmosphere.websocket.protocol.ProtocolUtil.constructRequest(ProtocolUtil.java:35)
       at org.atmosphere.websocket.protocol.SimpleHttpProtocol.onMessage(SimpleHttpProtocol.java:136)
       at org.atmosphere.websocket.DefaultWebSocketProcessor.invokeWebSocketProtocol(DefaultWebSocketProcessor.java:464)
       at org.atmosphere.nettosphere.BridgeRuntime.handleWebSocketFrame(BridgeRuntime.java:347)
       at org.atmosphere.nettosphere.BridgeRuntime.messageReceived(BridgeRuntime.java:270)
       at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
       at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
       at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
       at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleUpstream(ChunkedWriteHandler.java:142)
       at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
       at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
       at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:296)
       at org.jboss.netty.handler.codec.frame.FrameDecoder.unfoldAndFireMessageReceived(FrameDecoder.java:462)
       at org.jboss.netty.handler.codec.replay.ReplayingDecoder.callDecode(ReplayingDecoder.java:536)
       at org.jboss.netty.handler.codec.replay.ReplayingDecoder.messageReceived(ReplayingDecoder.java:435)
       at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
       at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
       at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:559)
       at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:268)
       at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:255)
       at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:88)
       at org.jboss.netty.channel.socket.nio.AbstractNioWorker.process(AbstractNioWorker.java:108)
       at org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
       at org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89)
       at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
       at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
       at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
       at java.lang.Thread.run(Thread.java:745)
2015-03-23 14:51:32 DEBUG BridgeRuntime:620 - Error 500 Internal Server Error for null
Message received! 1817199655410156
Connection established!
User {89eaa38e-c3c0-4ba1-9c5f-13d2f3f6ab6e} connected.
2015-03-23 14:51:32 WARN  TrackMessageSizeInterceptor:135 - Cannot use TrackMessageSizeInterceptor with binary write. Writing the message as it is.
Message received! 1817199655410157
2015-03-23 14:51:32 WARN  TrackMessageSizeInterceptor:135 - Cannot use TrackMessageSizeInterceptor with binary write. Writing the message as it is.
2015-03-23 14:51:48 DEBUG IdleResourceInterceptor:91 - IdleResourceInterceptor disconnecting AtmosphereResource{
       uuid=89eaa38e-c3c0-4ba1-9c5f-13d2f3f6ab6e,
       transport=WEBSOCKET,
       isInScope=true,
       isResumed=false,
       isCancelled=false,
       isSuspended=true,
       broadcaster=/atmosphere size: 1,
       isClosedByClient=false,
       isClosedByApplication=false,
       action=Action{timeout=-1, type=SUSPEND}}
User {89eaa38e-c3c0-4ba1-9c5f-13d2f3f6ab6e} unexpectedly disconnected

jfarcand · 2015-03-25T13:07:10Z

@albertdabrowski Please test with 2.3.0-SNAPSHOT https://github.com/Atmosphere/atmosphere/wiki/Downloading-Atmosphere's-SNAPSHOT and let me know if you still experiencing the issue.

albertdabrowski · 2015-03-26T13:34:50Z

I experience the same effect on that snapshot version. Did test on stable 2.2.6 but was the same effect.

jfarcand · 2015-03-26T14:45:18Z

@albertdabrowski Please share the stack trace obtained with 2.3.0-SNAPSHOT.

albertdabrowski · 2015-03-26T15:03:56Z

Regarding Unit Test I'm doing here, it sent random binary data to the server which in response send back the status. I switched that into binary mode. Anyway I do the test without waiting for response from the server. It simply fires next message once the previous one is already sent (not waiting for response to receive on Function)

2015-03-26 15:58:44 WARN  TrackMessageSizeInterceptor:135 - Cannot use TrackMessageSizeInterceptor with binary write. Writing the message as it is.
2015-03-26 15:58:44 DEBUG BridgeRuntime:682 - Exception
java.util.ConcurrentModificationException
    at java.util.HashMap$HashIterator.nextNode(HashMap.java:1429)
    at java.util.HashMap$EntryIterator.next(HashMap.java:1463)
    at java.util.HashMap$EntryIterator.next(HashMap.java:1461)
    at org.atmosphere.websocket.protocol.ProtocolUtil.attributes(ProtocolUtil.java:57)
    at org.atmosphere.websocket.protocol.ProtocolUtil.constructRequest(ProtocolUtil.java:35)
    at org.atmosphere.websocket.protocol.SimpleHttpProtocol.onMessage(SimpleHttpProtocol.java:136)
    at org.atmosphere.websocket.DefaultWebSocketProcessor.invokeWebSocketProtocol(DefaultWebSocketProcessor.java:464)
    at org.atmosphere.nettosphere.BridgeRuntime.handleWebSocketFrame(BridgeRuntime.java:347)
    at org.atmosphere.nettosphere.BridgeRuntime.messageReceived(BridgeRuntime.java:270)
    at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
    at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
    at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
    at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleUpstream(ChunkedWriteHandler.java:142)
    at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
    at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
    at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:296)
    at org.jboss.netty.handler.codec.frame.FrameDecoder.unfoldAndFireMessageReceived(FrameDecoder.java:462)
    at org.jboss.netty.handler.codec.replay.ReplayingDecoder.callDecode(ReplayingDecoder.java:536)
    at org.jboss.netty.handler.codec.replay.ReplayingDecoder.messageReceived(ReplayingDecoder.java:435)
    at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
    at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
    at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:559)
    at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:268)
    at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:255)
    at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:88)
    at org.jboss.netty.channel.socket.nio.AbstractNioWorker.process(AbstractNioWorker.java:108)
    at org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
    at org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89)
    at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
    at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
    at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
2015-03-26 15:58:44 DEBUG BridgeRuntime:620 - Error 500 Internal Server Error for null
User {494c4e48-ccf8-469b-98f9-6d16e083dd02} unexpectedly disconnected
2015-03-26 15:58:44 DEBUG Processor:114 - Channel Closed: [id: 0x1882c562, /127.0.0.1:57075 :> localhost/127.0.0.1:8080] with attribute NettyResponseFuture{currentRetry=5,
    isDone=true,
    isCancelled=false,
    asyncHandler=org.atmosphere.wasync.transport.WebSocketTransport@691a7e39,
    nettyRequest=com.ning.http.client.providers.netty.request.NettyRequest@3d408364,
    content=NettyWebSocket{channel=[id: 0x1882c562, /127.0.0.1:57075 :> localhost/127.0.0.1:8080]},
    uri=ws://localhost:8080/atmosphere,
    keepAlive=true,
    httpHeaders=org.jboss.netty.handler.codec.http.DefaultHttpHeaders@4dc16a2e,
    exEx=null,
    redirectCount=0,
    timeoutsHolder=null,
    inAuth=false,
    statusReceived=false,
    touch=1526381207}
2015-03-26 15:58:44 WARN  WebSocketTransport:169 - 
java.io.IOException: Invalid Socket Status CLOSE
    at org.atmosphere.wasync.impl.SocketRuntime.write(SocketRuntime.java:90)
    at org.atmosphere.wasync.impl.DefaultSocket.fire(DefaultSocket.java:82)
    at com.motorolasolutions.bigdata.ws2kafka.Ws2kafkaTest.testManyMessagesOverWebSocket(Ws2kafkaTest.java:91)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:497)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
    at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
    at org.mockito.internal.runners.JUnit45AndHigherRunnerImpl.run(JUnit45AndHigherRunnerImpl.java:37)
    at org.mockito.runners.MockitoJUnitRunner.run(MockitoJUnitRunner.java:62)
    at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
    at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
2015-03-26 15:58:44 INFO  WebSocketTransport:297 - try reconnect : attempt [1/0]

jfarcand · 2015-03-26T15:16:13Z

@albertdabrowski You aren't using the latest SNAPSHOT http://goo.gl/g3oH83

albertdabrowski · 2015-03-26T15:43:19Z

I cannot get this snapshot through maven due to my proxy issue, so I downloaded it manually and put it into classpath. Please let me know if the version atmosphere-runtime-2.3.0-20150325.173055-217.jar is the right jar? I found that's the latest one from the repo You sent me.

albertdabrowski · 2015-03-27T12:47:08Z

Ok, I see that You did a change on master, so I did a test and this time sometimes it works sometimes not (got the same ConcurrentModificationException. I think that problem is that in Your change You take a view, but this is not a copy of map, so if that map is modified somewhere else then the same exception occurs

catch (Exception ex) {
            ...
            Map<String, Object> dup = Collections.unmodifiableMap(request.localAttributes());
            ...

change to

catch (Exception ex) {
            ...
            Map<String, Object> dup = Collections.unmodifiableMap(new HashMap(request.localAttributes()));
            ...

albertdabrowski · 2015-04-01T14:38:44Z

Ok, here I created simple Unit Test with this and You may check that it
fails. BTW, I did a check on just sending info to the client and that
works. The problem arise when atmopshere send the message back to the
client. I think You still need that synchronization or I miss some other
knowledge from Your implementation.

Regards,
Albert

2015-04-01 14:49 GMT+02:00 Jeanfrancois Arcand notifications@github.com:

Reopened #1908 #1908.

—
Reply to this email directly or view it on GitHub
#1908 (comment).

jfarcand · 2015-04-01T19:26:42Z

@albertdabrowski Please share the test :-)

albertdabrowski · 2015-04-02T09:22:13Z

I cannot add it here the zip file with small project having this test, I've sent to You in attachmment over mail, please have a look.

jfarcand · 2015-04-16T22:04:27Z

@albertdabrowski Any update? I've never received your .zip

albertdabrowski · 2015-04-16T22:13:07Z

I've sent it once again to the jfarcand.oss@gmail.com

albertdabrowski · 2015-04-20T09:01:25Z

Let me know when the new version will be available. Thanks in advance

jfarcand added the 2.3.0 label Mar 25, 2015

jfarcand closed this as completed in 05c7aab Mar 25, 2015

albertdabrowski pushed a commit to albertdabrowski/atmosphere that referenced this issue Mar 30, 2015

Recommended fix for Atmosphere#1908

ca64550

jfarcand mentioned this issue Mar 31, 2015

[Performance] [WebSocket] Avoid coyping parent attributes #1931

Closed

jfarcand added a commit that referenced this issue Mar 31, 2015

Fixes #1930, Fixes #1908

156d15f

jfarcand added a commit that referenced this issue Mar 31, 2015

Fixes #1930, Fixes #1908

821c6dd

jfarcand reopened this Apr 1, 2015

jfarcand closed this as completed Apr 16, 2015

jfarcand reopened this Apr 16, 2015

jfarcand added a commit that referenced this issue Apr 17, 2015

🐛 Fixes for #1908

ab4bbd8

jfarcand closed this as completed Apr 17, 2015

jfarcand added the 2.2.7 label Apr 17, 2015

jfarcand added a commit that referenced this issue Apr 17, 2015

🐛 Fixes for #1908

70c7f00

jfarcand added the Performance label Apr 21, 2015

timofeevda mentioned this issue Jul 14, 2015

ConcurrentModificationException in WebSocket.shiftAttributes method #2021

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ConcurrentModificationException on atmosphere websocket connection #1908

ConcurrentModificationException on atmosphere websocket connection #1908

albertdabrowski commented Mar 25, 2015

jfarcand commented Mar 25, 2015

albertdabrowski commented Mar 26, 2015

jfarcand commented Mar 26, 2015

albertdabrowski commented Mar 26, 2015

jfarcand commented Mar 26, 2015

albertdabrowski commented Mar 26, 2015

albertdabrowski commented Mar 27, 2015

albertdabrowski commented Apr 1, 2015

jfarcand commented Apr 1, 2015

albertdabrowski commented Apr 2, 2015

jfarcand commented Apr 16, 2015

albertdabrowski commented Apr 16, 2015

albertdabrowski commented Apr 20, 2015

ConcurrentModificationException on atmosphere websocket connection #1908

ConcurrentModificationException on atmosphere websocket connection #1908

Comments

albertdabrowski commented Mar 25, 2015

jfarcand commented Mar 25, 2015

albertdabrowski commented Mar 26, 2015

jfarcand commented Mar 26, 2015

albertdabrowski commented Mar 26, 2015

jfarcand commented Mar 26, 2015

albertdabrowski commented Mar 26, 2015

albertdabrowski commented Mar 27, 2015

albertdabrowski commented Apr 1, 2015

jfarcand commented Apr 1, 2015

albertdabrowski commented Apr 2, 2015

jfarcand commented Apr 16, 2015

albertdabrowski commented Apr 16, 2015

albertdabrowski commented Apr 20, 2015