This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Upgrade to latest deps: prevent false positives on modern Coffee syntax #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ax, such as import/export
Arcanemagus
suggested changes
Oct 26, 2016
| @@ -2,7 +2,7 @@ | |||
| "name": "linter-coffeelint", | |||
| "main": "./lib/init", | |||
| "activationCommands": {}, | |||
| "version": "1.1.2", | |||
| "version": "1.2.0", | |||
There was a problem hiding this comment.
Don't update the version, this will be done when releasing a new version.
| "atom-package-deps": "3.0.6", | ||
| "coffeelint": "1.9.7", | ||
| "resolve": "1.1.5" | ||
| "atom-package-deps": "4.3.1", |
There was a problem hiding this comment.
Can this be made a range please.
| "resolve": "1.1.5" | ||
| "atom-package-deps": "4.3.1", | ||
| "coffeelint": "1.16.0", | ||
| "resolve": "1.1.7" |
There was a problem hiding this comment.
Again, this should be a range as it's a utility library.
|
Very interesting... it looks like somebody disabled GreenKeeper on this repository, so none of the PRs that should have been coming in updating this have well... been coming in. 😠 |
|
Went ahead and made the changes in #70, thanks for bringing this up! |
|
Published v1.2.0, now to add specs and clean up the rest of this mess. |
|
@Arcanemagus awesome, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such as import/export