This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Fix file import resolution #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| filePath = Path.relative(eslintignoreDir, params.filePath) | ||
| process.chdir(eslintignoreDir) | ||
| } else { | ||
| filePath = Path.basename(params.filePath) |
There was a problem hiding this comment.
Wouldn't it be nice to move this here?
There was a problem hiding this comment.
Ah, completely missed that. Yes, indeed it would. One moment.
By default, process.cwd is the directory containing the file being linted, so normally it is only necessary to provide the name of the file itself, with no path. But, if a .gitignore file is present, eslint will not properly ignore a file if cwd is not set to the project root when executing with text and providing a filename, as we are doing. So, if we find an .eslintignore, we can simply change the cwd to the root directory (same directory as the .eslintignore).
|
LGTM, merge if CI passes |
|
I guess AppVeyor isn't working correctly? https://ci.appveyor.com/project/Arcanemagus/linter-eslint/build/51 |
|
AppVeyor will be broken till v1.3.0 is released (see atom/atom#9277), hence why it isn't marked as required 😉. |
|
Thanks @Arcanemagus. This look okay to you? |
| @@ -19,9 +19,10 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "babel-eslint": "^4.1.5", | |||
| "eslint-plugin-react": "^3.10.0", | |||
| "eslint-config-airbnb": "latest", | |||
There was a problem hiding this comment.
npm i --save-dev does this automatically, apparently.
|
Looks good to me 👍. |
This was referenced Dec 8, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #335
I originally didn't realize that
process.cwd()is always the directory of the file being linted. Because of this, it's possible to pass in only the basename of the file, and ESLint will assume cwd is set correctly, and will resolve configs and imports.But, this breaks use of
.eslintignorefiles, so if one of those are found, we can set cwd to the project root and pass the relative path to eslint.